qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3] hw/usb/vt82c686-uhci-pci: Use ISA instead of PCI interrup


From: BALATON Zoltan
Subject: Re: [PATCH v3] hw/usb/vt82c686-uhci-pci: Use ISA instead of PCI interrupts
Date: Thu, 14 Oct 2021 12:22:58 +0200 (CEST)

On Thu, 14 Oct 2021, Gerd Hoffmann wrote:
On Wed, Oct 13, 2021 at 02:13:09PM +0200, BALATON Zoltan wrote:
This device is part of a superio/ISA bridge chip and IRQs from it are
routed to an ISA interrupt set by the Interrupt Line PCI config
register. Change uhci_update_irq() to allow this and implement it in
vt82c686-uhci-pci.

Looks good.  There are some unrelated changes in though (whitespace,
comments, ...), and the vt82c686-uhci-pci.c changes should be a
separate patch.

So you mean split it into a series of three small patches? Should I do a w4 with that?

Regards,
BALATON Zoltan



reply via email to

[Prev in Thread] Current Thread [Next in Thread]