Re: [PATCH v3 0/3] hw/mips/boston: ELF kernel support

[Philippe Mathieu-Daudé]

On 10/11/21 15:58, Jiaxun Yang wrote:
> ping?
> 
> 在 2021/10/2 19:45, Jiaxun Yang 写道:
>> Jiaxun Yang (3):
>>    hw/mips/boston: Massage memory map information
>>    hw/mips/boston: Allow loading elf kernel and dtb
>>    hw/mips/boston: Add FDT generator

Next time please run checkpatch.pl before submitting,
see
https://blog.vmsplice.net/2011/03/how-to-automatically-run-checkpatchpl.html

2/4 Checking commit 5c65dfb784f3 (hw/mips/boston: Massage memory map
information)
WARNING: line over 80 characters
#108: FILE: hw/mips/boston.c:372:
+                                 1, boston_memmap[BOSTON_LOWDDR].base,
1, ram_low_sz,

WARNING: line over 80 characters
#109: FILE: hw/mips/boston.c:373:
+                                 1, boston_memmap[BOSTON_HIGHDDR].base
+ ram_low_sz,

WARNING: line over 80 characters
#119: FILE: hw/mips/boston.c:478:
+    memory_region_init_rom(flash, NULL, "boston.flash",
boston_memmap[BOSTON_FLASH].size,

WARNING: line over 80 characters
#122: FILE: hw/mips/boston.c:480:
+    memory_region_add_subregion_overlap(sys_mem,
boston_memmap[BOSTON_FLASH].base,

WARNING: line over 80 characters
#126: FILE: hw/mips/boston.c:483:
+    memory_region_add_subregion_overlap(sys_mem,
boston_memmap[BOSTON_HIGHDDR].base,

WARNING: line over 80 characters
#178: FILE: hw/mips/boston.c:526:
+    memory_region_add_subregion_overlap(sys_mem,
boston_memmap[BOSTON_LCD].base, lcd, 0);

3/4 Checking commit 5bb14fa00b48 (hw/mips/boston: Allow loading elf
kernel and dtb)
WARNING: line over 80 characters
#58: FILE: hw/mips/boston.c:567:
+                dtb_load_data = boston_fdt_filter(s, dtb_file_data,
NULL, &dtb_vaddr);

4/4 Checking commit 04f5b1319a3d (hw/mips/boston: Add FDT generator)
WARNING: line over 80 characters
#56: FILE: hw/mips/boston.c:459:
+    qemu_fdt_setprop_string(fdt, name, "compatible",
"xlnx,axi-pcie-host-1.00.a");

WARNING: line over 80 characters
#92: FILE: hw/mips/boston.c:495:
+    qemu_fdt_setprop(fdt, name, "interrupt-map", &interrupt_map,
sizeof(interrupt_map));

WARNING: line over 80 characters
#98: FILE: hw/mips/boston.c:501:
+static const void *create_fdt(BostonState *s, const MemMapEntry
*memmap, int *dt_size)

WARNING: line over 80 characters
#105: FILE: hw/mips/boston.c:508:
+    static const char * const syscon_compat[2] =
{"img,boston-platform-regs", "syscon"};

WARNING: line over 80 characters
#144: FILE: hw/mips/boston.c:547:
+    fdt_create_pcie(fdt, gic_ph, 2, memmap[BOSTON_PCIE0].base,
memmap[BOSTON_PCIE0].size,

WARNING: line over 80 characters
#145: FILE: hw/mips/boston.c:548:
+                    memmap[BOSTON_PCIE0_MMIO].base,
memmap[BOSTON_PCIE0_MMIO].size);

WARNING: line over 80 characters
#147: FILE: hw/mips/boston.c:550:
+    fdt_create_pcie(fdt, gic_ph, 1, memmap[BOSTON_PCIE1].base,
memmap[BOSTON_PCIE1].size,

WARNING: line over 80 characters
#148: FILE: hw/mips/boston.c:551:
+                    memmap[BOSTON_PCIE1_MMIO].base,
memmap[BOSTON_PCIE1_MMIO].size);

WARNING: line over 80 characters
#150: FILE: hw/mips/boston.c:553:
+    fdt_create_pcie(fdt, gic_ph, 0, memmap[BOSTON_PCIE2].base,
memmap[BOSTON_PCIE2].size,

WARNING: line over 80 characters
#151: FILE: hw/mips/boston.c:554:
+                    memmap[BOSTON_PCIE2_MMIO].base,
memmap[BOSTON_PCIE2_MMIO].size);

WARNING: line over 80 characters
#196: FILE: hw/mips/boston.c:599:
+    qemu_fdt_setprop_cells(fdt, platreg_name, "reg",
memmap[BOSTON_PLATREG].base,

WARNING: line over 80 characters
#278: FILE: hw/mips/boston.c:786:
+            dtb_load_data = boston_fdt_filter(s, dtb_file_data, NULL,
&dtb_vaddr);

For now I'll fix that locally.