[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 4/4] configure: remove dead EXESUF variable
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH 4/4] configure: remove dead EXESUF variable |
|
Date: |
Fri, 15 Oct 2021 16:23:08 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0 |
On 10/15/21 15:36, Paolo Bonzini wrote:
> On 15/10/21 14:38, Philippe Mathieu-Daudé wrote:
>> On 10/15/21 12:07, Paolo Bonzini wrote:
>>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>>> ---
>>> .gitlab-ci.d/crossbuild-template.yml | 2 +-
>>> configure | 3 ---
>>> 2 files changed, 1 insertion(+), 4 deletions(-)
>>
>> Maybe squash in patch #2 or place as #3 mentioning
>> "the previous commit"?
>
> Anywhere you place it it's wrong. :) Squashing in #2 I dislike because
> of the functional change in .gilab-ci.d (in truth, the variable is
> *almost* dead!). Having the change as #4 makes it survive one patch
> longer than it should, on the other hand having it as #3 separates
> similar changes to "check-block.sh".
Indeed.
> What I will actually do in the final submission is not include the TAP
> patch and submit it separately. Then for this one I can indeed add that
> it was used only in the implementation of check-block.
OK then,
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>