[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 03/24] target/avr: Drop checks for singlestep_enabled
From: |
Richard Henderson |
Subject: |
[PULL 03/24] target/avr: Drop checks for singlestep_enabled |
Date: |
Sat, 16 Oct 2021 11:14:53 -0700 |
GDB single-stepping is now handled generically.
Tested-by: Michael Rolnik <mrolnik@gmail.com>
Reviewed-by: Michael Rolnik <mrolnik@gmail.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/avr/translate.c | 19 ++++---------------
1 file changed, 4 insertions(+), 15 deletions(-)
diff --git a/target/avr/translate.c b/target/avr/translate.c
index 438e7b13c1..af8a3e0f9c 100644
--- a/target/avr/translate.c
+++ b/target/avr/translate.c
@@ -1087,11 +1087,7 @@ static void gen_goto_tb(DisasContext *ctx, int n,
target_ulong dest)
tcg_gen_exit_tb(tb, n);
} else {
tcg_gen_movi_i32(cpu_pc, dest);
- if (ctx->base.singlestep_enabled) {
- gen_helper_debug(cpu_env);
- } else {
- tcg_gen_lookup_and_goto_ptr();
- }
+ tcg_gen_lookup_and_goto_ptr();
}
ctx->base.is_jmp = DISAS_NORETURN;
}
@@ -3009,17 +3005,10 @@ static void avr_tr_tb_stop(DisasContextBase *dcbase,
CPUState *cs)
tcg_gen_movi_tl(cpu_pc, ctx->npc);
/* fall through */
case DISAS_LOOKUP:
- if (!ctx->base.singlestep_enabled) {
- tcg_gen_lookup_and_goto_ptr();
- break;
- }
- /* fall through */
+ tcg_gen_lookup_and_goto_ptr();
+ break;
case DISAS_EXIT:
- if (ctx->base.singlestep_enabled) {
- gen_helper_debug(cpu_env);
- } else {
- tcg_gen_exit_tb(NULL, 0);
- }
+ tcg_gen_exit_tb(NULL, 0);
break;
default:
g_assert_not_reached();
--
2.25.1
- [PULL 11/24] target/microblaze: Check CF_NO_GOTO_TB for DISAS_JUMP, (continued)
- [PULL 11/24] target/microblaze: Check CF_NO_GOTO_TB for DISAS_JUMP, Richard Henderson, 2021/10/16
- [PULL 18/24] target/riscv: Remove exit_tb and lookup_and_goto_ptr, Richard Henderson, 2021/10/16
- [PULL 17/24] target/riscv: Remove dead code after exception, Richard Henderson, 2021/10/16
- [PULL 02/24] target/alpha: Drop checks for singlestep_enabled, Richard Henderson, 2021/10/16
- [PULL 06/24] target/arm: Drop checks for singlestep_enabled, Richard Henderson, 2021/10/16
- [PULL 15/24] target/openrisc: Drop checks for singlestep_enabled, Richard Henderson, 2021/10/16
- [PULL 20/24] target/s390x: Drop check for singlestep_enabled, Richard Henderson, 2021/10/16
- [PULL 24/24] Revert "cpu: Move cpu_common_props to hw/core/cpu.c", Richard Henderson, 2021/10/16
- [PULL 08/24] target/i386: Check CF_NO_GOTO_TB for dc->jmp_opt, Richard Henderson, 2021/10/16
- [PULL 22/24] target/tricore: Drop check for singlestep_enabled, Richard Henderson, 2021/10/16
- [PULL 03/24] target/avr: Drop checks for singlestep_enabled,
Richard Henderson <=
- [PULL 13/24] target/mips: Fix single stepping, Richard Henderson, 2021/10/16
- [PULL 16/24] target/ppc: Drop exit checks for singlestep_enabled, Richard Henderson, 2021/10/16
- [PULL 19/24] target/rx: Drop checks for singlestep_enabled, Richard Henderson, 2021/10/16
- [PULL 23/24] target/xtensa: Drop check for singlestep_enabled, Richard Henderson, 2021/10/16
- [PULL 21/24] target/sh4: Drop check for singlestep_enabled, Richard Henderson, 2021/10/16
- Re: [PULL 00/24] tcg patch queue, Richard Henderson, 2021/10/16