qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 14/14] target/riscv: Compute mstatus.sd on demand


From: Alistair Francis
Subject: Re: [PATCH v3 14/14] target/riscv: Compute mstatus.sd on demand
Date: Mon, 18 Oct 2021 15:38:12 +1000

On Mon, Oct 18, 2021 at 3:31 PM Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> On 10/17/21 9:52 PM, Alistair Francis wrote:
> > On Sun, Oct 17, 2021 at 3:32 AM Richard Henderson
> > <richard.henderson@linaro.org> wrote:
> >>
> >> The position of this read-only field is dependent on the
> >> current cpu width.  Rather than having to compute that
> >> difference in many places, compute it only on read.
> >>
> >> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> >
> > This means that the value reported by riscv_cpu_dump_state() and GDB
> > will both be incorrect though?
>
> Yep.  Missed those; should have added another accessor.

Do we get much of an advantage from this though? To me it seems
confusing that the mstatus register doesn't actually contain the
latest value (for example when debugging QEMU and adding my own
printf's).

>
> Also, for the record, it changes the vmstate, but since a previous patch in 
> the series
> bumped the version number for the split on misa, we can call all of a piece 
> and ok.

Works for me :)

Alistair

>
>
> r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]