Re: [PATCH 2/2] roms/edk2: Only initialize required submodules

[Philippe Mathieu-Daudé]

Cc'ing Michael, since the make-release script is not covered
in any MAINTAINERS section.

On 10/18/21 11:31, Philippe Mathieu-Daudé wrote:
> On 10/18/21 11:23, Philippe Mathieu-Daudé wrote:
>> The EDK2 firmware images built to test QEMU do not require
>> the following submodules:
>>
>>  - MdeModulePkg/Universal/RegularExpressionDxe/oniguruma
>>  - UnitTestFrameworkPkg/Library/CmockaLib/cmocka
>>
>> The only submodules required are:
>>
>>  - ArmPkg/Library/ArmSoftFloatLib/berkeley-softfloat-3
>>  - BaseTools/Source/C/BrotliCompress/brotli
>>  - CryptoPkg/Library/OpensslLib/openssl
>>  - MdeModulePkg/Library/BrotliCustomDecompressLib/brotli
>>
>> Adapt the buildsys machinery to only initialize the required
>> submodules.
>>
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>> ---
>>  .gitlab-ci.d/edk2.yml | 4 ++++
>>  roms/Makefile.edk2    | 7 ++++++-
>>  scripts/make-release  | 7 ++++++-
>>  3 files changed, 16 insertions(+), 2 deletions(-)
> 
>>  # See notes on the ".NOTPARALLEL" target and the "+" indicator in
>> diff --git a/scripts/make-release b/scripts/make-release
>> index a2a8cda33c0..a9ff933a4ca 100755
>> --- a/scripts/make-release
>> +++ b/scripts/make-release
>> @@ -27,7 +27,12 @@ git submodule update --init
>>  # don't necessarily have much control over how a submodule handles its
>>  # submodule dependencies, so we continue to handle these on a case-by-case
>>  # basis for now.
>> -(cd roms/edk2 && git submodule update --init)
>> +(cd roms/edk2 && \
>> +    git submodule update --init \
> 
> Hmm I forgot the '--' separator here.

BTW Michael since commit 9d03f5abede ("travis.yml: Remove the
"Release tarball" job") we don't test make-release anymore in
our CI, you might want to add some GitLab equivalent job.

Regards,

Phil.