[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/7] tests/docker: Use apt build-dep in debian10
From: |
Alex Bennée |
Subject: |
Re: [PATCH 1/7] tests/docker: Use apt build-dep in debian10 |
Date: |
Mon, 18 Oct 2021 11:53:20 +0100 |
User-agent: |
mu4e 1.7.0; emacs 28.0.60 |
Richard Henderson <richard.henderson@linaro.org> writes:
> Replace the complex apt-get subshell with apt build-dep.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> tests/docker/dockerfiles/debian10.docker | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/tests/docker/dockerfiles/debian10.docker
> b/tests/docker/dockerfiles/debian10.docker
> index b414af1b9f..d3bbb90c64 100644
> --- a/tests/docker/dockerfiles/debian10.docker
> +++ b/tests/docker/dockerfiles/debian10.docker
> @@ -14,7 +14,8 @@ RUN cat /etc/apt/sources.list | sed "s/^deb\ /deb-src /" >>
> /etc/apt/sources.lis
>
> # Install common build utilities
> RUN apt update && \
> - DEBIAN_FRONTEND=noninteractive apt install -yy eatmydata && \
> + DEBIAN_FRONTEND=noninteractive \
> + apt install -yy eatmydata && \
> DEBIAN_FRONTEND=noninteractive eatmydata \
> apt install -y --no-install-recommends \
> bc \
> @@ -33,5 +34,7 @@ RUN apt update && \
> psmisc \
> python3 \
> python3-sphinx \
> - python3-sphinx-rtd-theme \
> - $(apt-get -s build-dep --arch-only qemu | egrep ^Inst | fgrep
> '[all]' | cut -d\ -f2)
> + python3-sphinx-rtd-theme
> +
> +RUN DEBIAN_FRONTEND=noninteractive eatmydata \
> + apt build-dep -yy qemu
I'd rather preserve the --arch-only while moving it. Otherwise:
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
--
Alex Bennée
- [PATCH 0/7] tests: docker images for hexagon, nios2, microblaze, Richard Henderson, 2021/10/14
- [PATCH 3/7] tests/docker: Update debian-hexagon-cross to a newer toolchain, Richard Henderson, 2021/10/14
- [PATCH 4/7] gitlab-ci: Remove special casing for hexagon testing, Richard Henderson, 2021/10/14
- [PATCH 7/7] tests/tcg: Enable container_cross_cc for microblaze, Richard Henderson, 2021/10/14
- [PATCH 6/7] tests/docker: Add debian-microblaze-cross image, Richard Henderson, 2021/10/14
- [PATCH 5/7] tests/docker: Add debian-nios2-cross image, Richard Henderson, 2021/10/14