[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] Hexagon (target/hexagon) more tcg_constant_*
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH 1/2] Hexagon (target/hexagon) more tcg_constant_* |
Date: |
Tue, 19 Oct 2021 05:44:46 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0 |
On 10/12/21 11:31, Taylor Simpson wrote:
> Change additional tcg_const_tl to tcg_constant_tl
>
> Note that gen_pred_cancal had slot_mask initialized with tcg_const_tl.
> However, it is not constant throughout, so we initialize it with
> tcg_temp_new and replace the first use with the constant value.
>
> Inspired-by: Richard Henderson <richard.henderson@linaro.org>
> Inspired-by: Philippe Mathieu-Daud<C3><A9> <f4bug@amsat.org>
UTF-8 copy/paste mojibake, otherwise:
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> Signed-off-by: Taylor Simpson <tsimpson@quicinc.com>
> ---
> target/hexagon/gen_tcg.h | 9 +++------
> target/hexagon/macros.h | 7 +++----
> target/hexagon/translate.c | 3 +--
> target/hexagon/gen_tcg_funcs.py | 11 ++---------
> 4 files changed, 9 insertions(+), 21 deletions(-)