qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 02/21] memory: add a few defines for octo (128-bit) values


From: Richard Henderson
Subject: Re: [PATCH v3 02/21] memory: add a few defines for octo (128-bit) values
Date: Tue, 19 Oct 2021 11:00:26 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0

On 10/19/21 2:47 AM, Frédéric Pétrot wrote:
Introducing unsigned quad, signed quad, and octo accesses types
to handle load and store by 128-bit processors.

Signed-off-by: Frédéric Pétrot <frederic.petrot@univ-grenoble-alpes.fr>
---
  include/exec/memop.h | 8 +++++++-
  1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/include/exec/memop.h b/include/exec/memop.h
index c554bb0ee8..476ea6cdae 100644
--- a/include/exec/memop.h
+++ b/include/exec/memop.h
@@ -85,10 +85,13 @@ typedef enum MemOp {
      MO_UB    = MO_8,
      MO_UW    = MO_16,
      MO_UL    = MO_32,
+    MO_UQ    = MO_64,
      MO_SB    = MO_SIGN | MO_8,
      MO_SW    = MO_SIGN | MO_16,
      MO_SL    = MO_SIGN | MO_32,
-    MO_UQ     = MO_64,
+    MO_SQ    = MO_SIGN | MO_64,
+    MO_Q     = MO_64,
+    MO_O     = MO_128,

There's no point in removing MO_Q in one patch and adding it back in the next. And I guess we might as well name MO_O to MO_UO now.

@@ -105,9 +108,12 @@ typedef enum MemOp {
  #ifdef NEED_CPU_H
      MO_TEUW  = MO_TE | MO_UW,
      MO_TEUL  = MO_TE | MO_UL,
+    MO_TEUQ  = MO_TE | MO_UQ,
      MO_TESW  = MO_TE | MO_SW,
      MO_TESL  = MO_TE | MO_SL,
      MO_TEQ   = MO_TE | MO_UQ,
+    MO_TESQ  = MO_TE | MO_SQ,

These should have been renamed at the same time as MO_Q. Though it seems you are missing a rename of these throughout target/? Surely this patch does not build as-is.


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]