[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH V4 03/10] vhost-vdpa: prepare for the multiqueue support
From: |
Jason Wang |
Subject: |
Re: [PATCH V4 03/10] vhost-vdpa: prepare for the multiqueue support |
Date: |
Wed, 20 Oct 2021 10:50:31 +0800 |
On Mon, Oct 18, 2021 at 11:44 PM Stefano Garzarella <sgarzare@redhat.com> wrote:
>
> On Mon, Oct 11, 2021 at 12:28:22PM +0800, Jason Wang wrote:
> >Unlike vhost-kernel, vhost-vdpa adapts a single device multiqueue
> >model. So we need to simply use virtqueue index as the vhost virtqueue
> >index. This is a must for multiqueue to work for vhost-vdpa.
> >
> >Signed-off-by: Jason Wang <jasowang@redhat.com>
> >Message-Id: <20210907090322.1756-4-jasowang@redhat.com>
> >Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
> >Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> >---
> > hw/virtio/vhost-vdpa.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> >diff --git a/hw/virtio/vhost-vdpa.c b/hw/virtio/vhost-vdpa.c
> >index edac4017da..8587d30918 100644
> >--- a/hw/virtio/vhost-vdpa.c
> >+++ b/hw/virtio/vhost-vdpa.c
> >@@ -504,8 +504,8 @@ static int vhost_vdpa_get_vq_index(struct vhost_dev
> >*dev, int idx)
> > {
> > assert(idx >= dev->vq_index && idx < dev->vq_index + dev->nvqs);
>
> Should we also change this assert?
I think this assert applies to multi-queue as well.
Thanks
>
> Thanks,
> Stefano
>
> >
> >- trace_vhost_vdpa_get_vq_index(dev, idx, idx - dev->vq_index);
> >- return idx - dev->vq_index;
> >+ trace_vhost_vdpa_get_vq_index(dev, idx, idx);
> >+ return idx;
> > }
> >
> > static int vhost_vdpa_set_vring_ready(struct vhost_dev *dev)
> >--
> >2.25.1
> >
> >
>
- [PATCH V4 00/10] vhost-vDPA multiqueue, Jason Wang, 2021/10/11
- [PATCH V4 01/10] vhost-vdpa: open device fd in net_init_vhost_vdpa(), Jason Wang, 2021/10/11
- [PATCH V4 04/10] vhost-vdpa: let net_vhost_vdpa_init() returns NetClientState *, Jason Wang, 2021/10/11
- [PATCH V4 02/10] vhost-vdpa: classify one time request, Jason Wang, 2021/10/11
- [PATCH V4 06/10] vhost-net: control virtqueue support, Jason Wang, 2021/10/11
- [PATCH V4 03/10] vhost-vdpa: prepare for the multiqueue support, Jason Wang, 2021/10/11
- [PATCH V4 07/10] virtio-net: use "queue_pairs" instead of "queues" when possible, Jason Wang, 2021/10/11
- [PATCH V4 08/10] vhost: record the last virtqueue index for the virtio device, Jason Wang, 2021/10/11
- [PATCH V4 05/10] net: introduce control client, Jason Wang, 2021/10/11
- [PATCH V4 09/10] virtio-net: vhost control virtqueue support, Jason Wang, 2021/10/11
- [PATCH V4 10/10] vhost-vdpa: multiqueue support, Jason Wang, 2021/10/11
- Re: [PATCH V4 00/10] vhost-vDPA multiqueue, Michael S. Tsirkin, 2021/10/19