[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 4/5] aspeed/smc: Use a container for the flash mmio addres
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH v2 4/5] aspeed/smc: Use a container for the flash mmio address space |
|
Date: |
Thu, 21 Oct 2021 00:00:48 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0 |
On 10/18/21 15:26, Cédric Le Goater wrote:
> Because AddressSpaces must not be sysbus-mapped, commit e9c568dbc225
> ("hw/arm/aspeed: Do not sysbus-map mmio flash region directly, use
> alias") introduced an alias for the flash mmio region.
>
> Using a container is cleaner.
>
> Cc: Philippe Mathieu-Daudé <f4bug@amsat.org>
> Signed-off-by: Cédric Le Goater <clg@kaod.org>
> ---
> include/hw/ssi/aspeed_smc.h | 2 +-
> hw/ssi/aspeed_smc.c | 11 +++++++----
> 2 files changed, 8 insertions(+), 5 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
- [PATCH v2 0/5] aspeed/smc: Improve support for the alternate boot function, Cédric Le Goater, 2021/10/18
- [PATCH v2 1/5] aspeed/wdt: Introduce a container for the MMIO region, Cédric Le Goater, 2021/10/18
- [PATCH v2 4/5] aspeed/smc: Use a container for the flash mmio address space, Cédric Le Goater, 2021/10/18
- [PATCH v2 2/5] aspeed: Initialize the watchdog device models before the FMC models, Cédric Le Goater, 2021/10/18
- [PATCH v2 5/5] speed/sdhci: Add trace events, Cédric Le Goater, 2021/10/18
- [PATCH v2 3/5] aspeed/smc: Improve support for the alternate boot function, Cédric Le Goater, 2021/10/18
- Re: [PATCH v2 0/5] aspeed/smc: Improve support for the alternate boot function, Peter Delevoryas, 2021/10/20