[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v6 5/5] docs: add deprecation note about 'set_password' param
From: |
Markus Armbruster |
Subject: |
Re: [PATCH v6 5/5] docs: add deprecation note about 'set_password' param 'connected' |
Date: |
Thu, 21 Oct 2021 07:16:13 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) |
Stefan Reiter <s.reiter@proxmox.com> writes:
> Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
> ---
>
> Seperate patch since it read a bit unsure in the review, feel free to either
> drop or squash this.
>
> docs/about/deprecated.rst | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst
> index 0bed6ecb1d..1ad08e57d2 100644
> --- a/docs/about/deprecated.rst
> +++ b/docs/about/deprecated.rst
> @@ -228,6 +228,12 @@ Use the more generic commands ``block-export-add`` and
> ``block-export-del``
> instead. As part of this deprecation, where ``nbd-server-add`` used a
> single ``bitmap``, the new ``block-export-add`` uses a list of ``bitmaps``.
>
> +``set_password`` argument ``connected`` for VNC protocol (since 6.2)
> +''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''
> +
> +Only the value ``keep`` is and was ever supported for VNC. It is recommended
> to
> +just drop the argument.
> +
> System accelerators
> -------------------
This is okay. Possibly clearer:
Only the value ``keep`` is and was ever supported for VNC. The
(useless) argument will be dropped in a future version of QEMU.
Either phrasing is
Reviewed-by: Markus Armbruster <armbru@redhat.com>
- [PATCH v6 0/5] VNC-related HMP/QMP fixes, Stefan Reiter, 2021/10/20
- [PATCH v6 4/5] qapi/monitor: only allow 'keep' SetPasswordAction for VNC and deprecate, Stefan Reiter, 2021/10/20
- [PATCH v6 5/5] docs: add deprecation note about 'set_password' param 'connected', Stefan Reiter, 2021/10/20
- Re: [PATCH v6 5/5] docs: add deprecation note about 'set_password' param 'connected',
Markus Armbruster <=
- [PATCH v6 1/5] monitor/hmp: add support for flag argument with value, Stefan Reiter, 2021/10/20
- [PATCH v6 2/5] qapi/monitor: refactor set/expire_password with enums, Stefan Reiter, 2021/10/20
- [PATCH v6 3/5] qapi/monitor: allow VNC display id in set/expire_password, Stefan Reiter, 2021/10/20