Re: [PATCH v8 5/8] hw/acpi/aml-build: Add PPTT table

[wangyanan (Y)]

On 2021/10/21 17:08, Andrew Jones wrote:
> On Wed, Oct 20, 2021 at 08:53:00PM +0800, wangyanan (Y) wrote:
> > > > > > > Table 5-149 of 6.2 spec (6.2 May 2017) tells the rev shall be 1. Or is
> > > > > > > it an erratum somewhere I did miss?
> > > > > > Yes, the revision in 6.2 spec is 1. And it's 2 in spec 6.3.
> > > > > > So just to be sure, should I use the oldest revision ?
> > > > > If you need (and use) features (such as flags) introduced in 6.3 then
> > > > > you should say the code complies with 6.3 and update the above comment.
> > > > The comment /* ACPI 6.2: 5.2.29 Processor Properties Topology Table
> > > > (PPTT) */
> > > > tried to explain the first spec version where PPTT is introduced is 6.2.
> > > > But it may
> > > > adds some confusion. I think it's better to replace it with:
> > > > /*
> > > >    * ACPI spec 5.2.29 Processor Properties Topology Table (PPTT)
> > > >    * (Revision 6.2 or later)
> > > >    */
> > > >
> > > > just like our build_slit().
> > > That's not my understanding. I think we usually point to the latest spec
> > > revision you comply with, ie. in that case 6.3 chapter ...
> > Ok, I get it. Would
> > /*
> >   * ACPI spec, Revision 6.3
> >   * 5.2.29 Processor Properties Topology Table (PPTT)
> >   */
> > be ok ?
> Yes, we need to call out the oldest spec we can for the functionality
> we're using. In this case, we're using flags first defined in the 6.3
> spec, so we need to call out the 6.3 spec.
Agreed.

I have updated these comments as suggested in v9. And I just noticed
that Richard has taken that v9 into the target-arm tree.

Thanks,
Yanan