[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v7 3/4] qapi/monitor: allow VNC display id in set/expire_pass
From: |
Markus Armbruster |
Subject: |
Re: [PATCH v7 3/4] qapi/monitor: allow VNC display id in set/expire_password |
Date: |
Thu, 21 Oct 2021 12:38:05 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) |
Stefan Reiter <s.reiter@proxmox.com> writes:
> It is possible to specify more than one VNC server on the command line,
> either with an explicit ID or the auto-generated ones à la "default",
> "vnc2", "vnc3", ...
>
> It is not possible to change the password on one of these extra VNC
> displays though. Fix this by adding a "display" parameter to the
> "set_password" and "expire_password" QMP and HMP commands.
>
> For HMP, the display is specified using the "-d" value flag.
>
> For QMP, the schema is updated to explicitly express the supported
> variants of the commands with protocol-discriminated unions.
>
> Suggested-by: Markus Armbruster <armbru@redhat.com>
> Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
- [PATCH v7 0/4] VNC-related HMP/QMP fixes, Stefan Reiter, 2021/10/21
- [PATCH v7 1/4] monitor/hmp: add support for flag argument with value, Stefan Reiter, 2021/10/21
- [PATCH v7 4/4] qapi/monitor: only allow 'keep' SetPasswordAction for VNC and deprecate, Stefan Reiter, 2021/10/21
- [PATCH v7 3/4] qapi/monitor: allow VNC display id in set/expire_password, Stefan Reiter, 2021/10/21
- [PATCH v7 2/4] qapi/monitor: refactor set/expire_password with enums, Stefan Reiter, 2021/10/21
- Re: [PATCH v7 0/4] VNC-related HMP/QMP fixes, Markus Armbruster, 2021/10/21
- Re: [PATCH v7 0/4] VNC-related HMP/QMP fixes, Markus Armbruster, 2021/10/28