[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 1/5] hw/riscv: virt: Don't use a macro for the PLIC config
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH v2 1/5] hw/riscv: virt: Don't use a macro for the PLIC configuration |
Date: |
Fri, 22 Oct 2021 12:38:39 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0 |
On 10/22/21 08:01, Alistair Francis wrote:
> From: Alistair Francis <alistair.francis@wdc.com>
>
> Using a macro for the PLIC configuration doesn't make the code any
> easier to read. Instead it makes it harder to figure out what is going
> on, so let's remove it.
>
> Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
> Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
> ---
> include/hw/riscv/virt.h | 1 -
> hw/riscv/virt.c | 2 +-
> 2 files changed, 1 insertion(+), 2 deletions(-)
No cover letter, so using the first patch.
Series:
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>