Re: [PATCH v3] isa-applesmc: provide OSK forwarding on Apple hosts

[Laurent Vivier]

Le 22/10/2021 à 18:07, Vladislav Yaroshchuk a écrit :
> Hi, Laurent!
> Thank you for your review!
>
> пт, 22 окт. 2021 г. в 14:36, Laurent Vivier <laurent@vivier.eu 
> <mailto:laurent@vivier.eu>>:
...
>      > +        && !applesmc_read_host_osk(&host_osk)) {
>      > +        if (s->osk) {
>      > +            warn_report("provided isa-applesmc.osk "
>      > +                        "is overwritten with host OSK");
>      > +            g_free(s->osk);
>      > +        }
>      > +        s->osk = host_osk;
>      > +    }
>      > +
>      >       if (!s->osk || (strlen(s->osk) != 64)) {
>      >           warn_report("Using AppleSMC with invalid key");
>
>      >           s->osk = default_osk;
>
> [0] The behavior of `osk` property handle: when the wrong OSK is provided
> (or not provided at all) isa-applesmc uses `default_osk` and continues to work 
> fine.
> Only a warning is printed.
> Seems it's better to meet this "rule": when we can't read OSK from host-SMC just
> warn the user and continue with `default_osk`.

Ok, it sounds reasonable.

Thanks,
Laurent