[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 4/5] virtiofsd: Add a helper to stop all queues
From: |
Dr. David Alan Gilbert (git) |
Subject: |
[PULL 4/5] virtiofsd: Add a helper to stop all queues |
Date: |
Tue, 26 Oct 2021 11:29:32 +0100 |
From: Vivek Goyal <vgoyal@redhat.com>
Use a helper to stop all the queues. Later in the patch series I am
planning to use this helper at one more place later in the patch series.
Signed-off-by: Vivek Goyal <vgoyal@redhat.com>
Message-Id: <20210930153037.1194279-6-vgoyal@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
---
tools/virtiofsd/fuse_virtio.c | 22 +++++++++++++---------
1 file changed, 13 insertions(+), 9 deletions(-)
diff --git a/tools/virtiofsd/fuse_virtio.c b/tools/virtiofsd/fuse_virtio.c
index fcf12db9cd..baead08b28 100644
--- a/tools/virtiofsd/fuse_virtio.c
+++ b/tools/virtiofsd/fuse_virtio.c
@@ -740,6 +740,18 @@ static void fv_queue_cleanup_thread(struct fv_VuDev *vud,
int qidx)
vud->qi[qidx] = NULL;
}
+static void stop_all_queues(struct fv_VuDev *vud)
+{
+ for (int i = 0; i < vud->nqueues; i++) {
+ if (!vud->qi[i]) {
+ continue;
+ }
+
+ fuse_log(FUSE_LOG_INFO, "%s: Stopping queue %d thread\n", __func__, i);
+ fv_queue_cleanup_thread(vud, i);
+ }
+}
+
/* Callback from libvhost-user on start or stop of a queue */
static void fv_queue_set_started(VuDev *dev, int qidx, bool started)
{
@@ -870,15 +882,7 @@ int virtio_loop(struct fuse_session *se)
* Make sure all fv_queue_thread()s quit on exit, as we're about to
* free virtio dev and fuse session, no one should access them anymore.
*/
- for (int i = 0; i < se->virtio_dev->nqueues; i++) {
- if (!se->virtio_dev->qi[i]) {
- continue;
- }
-
- fuse_log(FUSE_LOG_INFO, "%s: Stopping queue %d thread\n", __func__, i);
- fv_queue_cleanup_thread(se->virtio_dev, i);
- }
-
+ stop_all_queues(se->virtio_dev);
fuse_log(FUSE_LOG_INFO, "%s: Exit\n", __func__);
return 0;
--
2.31.1
- [PULL 0/5] virtiofs queue, Dr. David Alan Gilbert (git), 2021/10/26
- [PULL 1/5] virtiofsd: xattr mapping add a new type "unsupported", Dr. David Alan Gilbert (git), 2021/10/26
- [PULL 2/5] virtiofsd: Remove unused virtio_fs_config definition, Dr. David Alan Gilbert (git), 2021/10/26
- [PULL 3/5] virtiofsd: Add a helper to send element on virtqueue, Dr. David Alan Gilbert (git), 2021/10/26
- [PULL 4/5] virtiofsd: Add a helper to stop all queues,
Dr. David Alan Gilbert (git) <=
- [PULL 5/5] virtiofsd: Error on bad socket group name, Dr. David Alan Gilbert (git), 2021/10/26
- Re: [PULL 0/5] virtiofs queue, Richard Henderson, 2021/10/26