Re: [PATCH v1 08/28] tests/tcg: Fix some targets default cross compiler path

[Philippe Mathieu-Daudé]

On 10/26/21 12:22, Alex Bennée wrote:
> From: Philippe Mathieu-Daudé <f4bug@amsat.org>
> 
> We do not want a shell command substitution, but a parameter
> substitution (with assignment). Replace $() -> ${}, otherwise
> the expanded command return an empty string and the $cross_cc
> variable is not set.
> 
> Fixes: 634ef789f8e ("tests/tcg: add more default compilers to configure.sh")

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> Message-Id: <20211023164329.328137-1-f4bug@amsat.org>
> ---
>  tests/tcg/configure.sh | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)