Re: [PATCH v3 40/48] tcg/optimize: Expand fold_addsub2_i32 to 64-bit ops

[Alex Bennée]

Richard Henderson <richard.henderson@linaro.org> writes:

> Rename to fold_addsub2.
> Use Int128 to implement the wider operation.
>
> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>  tcg/optimize.c | 65 ++++++++++++++++++++++++++++++++++----------------
>  1 file changed, 44 insertions(+), 21 deletions(-)
>
> diff --git a/tcg/optimize.c b/tcg/optimize.c
> index efd5f58137..ba068e7d3e 100644
> --- a/tcg/optimize.c
> +++ b/tcg/optimize.c
> @@ -24,6 +24,7 @@
>   */
>  
>  #include "qemu/osdep.h"
> +#include "qemu/int128.h"
>  #include "tcg/tcg-op.h"
>  #include "tcg-internal.h"
>  
> @@ -838,37 +839,59 @@ static bool fold_add(OptContext *ctx, TCGOp *op)
>      return false;
>  }
>  
> -static bool fold_addsub2_i32(OptContext *ctx, TCGOp *op, bool add)
> +static bool fold_addsub2(OptContext *ctx, TCGOp *op, bool add)

I see diff had an aneurysm...

Anyway:

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>

-- 
Alex Bennée