qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 10/15] iotests/297: split test into sub-cases


From: John Snow
Subject: Re: [PATCH v2 10/15] iotests/297: split test into sub-cases
Date: Tue, 26 Oct 2021 14:02:04 -0400



On Tue, Oct 26, 2021 at 6:29 AM Hanna Reitz <hreitz@redhat.com> wrote:
On 19.10.21 16:49, John Snow wrote:
> Take iotest 297's main() test function and split it into two sub-cases
> that can be skipped individually. We can also drop custom environment
> setup from the pylint test as it isn't needed.
>
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
>   tests/qemu-iotests/297 | 63 ++++++++++++++++++++++++++----------------
>   1 file changed, 39 insertions(+), 24 deletions(-)

Reviewed-by: Hanna Reitz <hreitz@redhat.com>

(while heavily scratching myself to ease the itch to turn this into a
unit test now)


(I strongly considered it, but didn't want to add yet-more-rewrites into this series. If the ultimate fate is to sunset this particular iotest, I didn't see a big benefit to doing it.)

reply via email to

[Prev in Thread] Current Thread [Next in Thread]