qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 0/8] Some Sphinx improvements


From: John Snow
Subject: Re: [PATCH v2 0/8] Some Sphinx improvements
Date: Tue, 26 Oct 2021 17:10:34 -0400



On Fri, Oct 15, 2021 at 6:57 AM <marcandre.lureau@redhat.com> wrote:
From: Marc-André Lureau <marcandre.lureau@redhat.com>

Hi,

I have collected a few Sphinx-related improvements to improve depfile generation
and add some keyboard navigation. Hope you'll like it.

v2:
 - fix test 'output:' regression
 - fix _javascript_ indentation (Paolo)
 - split "meson: remove explicit extensions dependency file list" (Paolo)

Marc-André Lureau (8):
  docs/sphinx: add loaded modules to generated depfile
  docs/sphinx: add static files to generated depfile
  docs/sphinx: add templates files to generated depfile
  tests/qapi-schema/meson: add depfile to sphinx doc
  meson: drop sphinx_extn_depends
  meson: drop sphinx_template_files
  docs/sphinx: set navigation_with_keys=True
  docs/sphinx: add 's' keyboard binding to focus search

 docs/conf.py                  |  7 ++++++-
 docs/meson.build              | 10 ----------
 docs/sphinx-static/custom.js  |  9 +++++++++
 docs/sphinx/depfile.py        | 19 +++++++++++++++++--
 tests/qapi-schema/meson.build |  6 ++++--
 5 files changed, 36 insertions(+), 15 deletions(-)
 create mode 100644 docs/sphinx-static/custom.js

--
2.33.0.721.g106298f7f9


The _javascript_ blurb selecting the correct DOM node being any better probably requires the search input box itself being given an 'id' parameter, but I don't know if that's something the theme we're using allows us to customize in any way. I'm not a webdev at all, so ... I'll assume it's fine?

Reviewed-by: John Snow <jsnow@redhat.com>

 

reply via email to

[Prev in Thread] Current Thread [Next in Thread]