|
From: | Richard Henderson |
Subject: | Re: [PATCH 3/6] hw/sh4: Change debug printfs to traces |
Date: | Tue, 26 Oct 2021 19:13:59 -0700 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 |
On 10/26/21 6:32 PM, BALATON Zoltan wrote:
+ trace_sh_serial("write", size, offs, val); switch (offs) { case 0x00: /* SMR */ s->smr = val & ((s->feat & SH_SERIAL_FEAT_SCIF) ? 0x7b : 0xff); @@ -302,10 +298,7 @@ static uint64_t sh_serial_read(void *opaque, hwaddr offs, break; } } -#ifdef DEBUG_SERIAL - printf("sh_serial: read offs=0x%02x val=0x%x\n", - offs, ret); -#endif + trace_sh_serial("read ", size, offs, ret);
I suggest two separate sh_serial_{read,write} tracepoints. r~
[Prev in Thread] | Current Thread | [Next in Thread] |