Re: [PATCH v2 10/11] hw/intc/sh_intc: Clean up iomem region

[BALATON Zoltan]

On Wed, 27 Oct 2021, Philippe Mathieu-Daudé wrote:
> On 10/27/21 15:46, BALATON Zoltan wrote:
> > Fix the size of the iomem region and rename it to "intc" from
> > "interrupt-controller" which makes the info mtree output less wide as
> > it is already too wide because of all the aliases. Also drop the
> > format macro which was only used twice in close proximity so we can
> > just use the literal string instead without a macro definition.
> >
> > Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
> > ---
> >  hw/intc/sh_intc.c | 10 +++-------
> >  1 file changed, 3 insertions(+), 7 deletions(-)
>
> > -    memory_region_init_io(&desc->iomem, NULL, &sh_intc_ops, desc,
> > -                          "interrupt-controller", 0x100000000ULL);
> > +    memory_region_init_io(&desc->iomem, NULL, &sh_intc_ops, desc, "intc", 4);
>
> Why the region size change from 4GB -> 4B? Did you mean '4 * GiB'?

No, it's really just 4 bytes, like the sh_serial region is 0x28 bytes but 
previously these were unnecessarily allocated as 4GB and then mapped in 
sysmem via the small 4 byte (or 0x28 byte for sh_serial) alias regions 
only. So we don't actually need these to be 4GB as there's nothing beyond 
the actual length so just declare them the necessary size. (I'm thinking 
maybe later we can drop one of the P4 or A7 alias and map the actual iomem 
at one of these directly and use an alias for the other but that's a 
separate clean up later.)

Regards,
BALATON Zoltan