[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 13/18] hw/intc/sh_intc: Remove excessive parenthesis
From: |
BALATON Zoltan |
Subject: |
[PATCH v3 13/18] hw/intc/sh_intc: Remove excessive parenthesis |
Date: |
Wed, 27 Oct 2021 23:54:31 +0200 |
Drop unneded parenthesis and split up one complex expression to write
it with less brackets so it's easier to follow.
Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
---
hw/intc/sh_intc.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/hw/intc/sh_intc.c b/hw/intc/sh_intc.c
index 54803bc2ca..537fc503d4 100644
--- a/hw/intc/sh_intc.c
+++ b/hw/intc/sh_intc.c
@@ -23,7 +23,7 @@ void sh_intc_toggle_source(struct intc_source *source,
int pending_changed = 0;
int old_pending;
- if ((source->enable_count == source->enable_max) && (enable_adj == -1)) {
+ if (source->enable_count == source->enable_max && enable_adj == -1) {
enable_changed = -1;
}
source->enable_count += enable_adj;
@@ -68,7 +68,7 @@ void sh_intc_toggle_source(struct intc_source *source,
static void sh_intc_set_irq(void *opaque, int n, int level)
{
struct intc_desc *desc = opaque;
- struct intc_source *source = &(desc->sources[n]);
+ struct intc_source *source = &desc->sources[n];
if (level && !source->asserted) {
sh_intc_toggle_source(source, 0, 1);
@@ -164,7 +164,7 @@ static void sh_intc_locate(struct intc_desc *desc,
*modep = mode | INTC_MODE_IS_PRIO;
*datap = &pr->value;
*enums = pr->enum_ids;
- *first = (pr->reg_width / pr->field_width) - 1;
+ *first = pr->reg_width / pr->field_width - 1;
*width = pr->field_width;
return;
}
@@ -245,7 +245,8 @@ static void sh_intc_write(void *opaque, hwaddr offset,
}
for (k = 0; k <= first; k++) {
- mask = ((1 << width) - 1) << ((first - k) * width);
+ mask = (1 << width) - 1;
+ mask <<= (first - k) * width;
if ((*valuep & mask) == (value & mask)) {
continue;
--
2.21.4
- [PATCH v3 00/18] More SH4 clean ups, BALATON Zoltan, 2021/10/27
- [PATCH v3 02/18] hw//sh4: Use qemu_log instead of fprintf to stderr, BALATON Zoltan, 2021/10/27
- [PATCH v3 05/18] hw/char/sh_serial: Rename type sh_serial_state to SHSerialState, BALATON Zoltan, 2021/10/27
- [PATCH v3 06/18] hw/char/sh_serial: QOM-ify, BALATON Zoltan, 2021/10/27
- [PATCH v3 14/18] hw/intc/sh_intc: Use array index instead of pointer arithmetics, BALATON Zoltan, 2021/10/27
- [PATCH v3 07/18] hw/char/sh_serial: Add device id to trace output, BALATON Zoltan, 2021/10/27
- [PATCH v3 13/18] hw/intc/sh_intc: Remove excessive parenthesis,
BALATON Zoltan <=
- [PATCH v3 01/18] hw/sh4: Fix typos in a comment, BALATON Zoltan, 2021/10/27
- [PATCH v3 09/18] hw/intc/sh_intc: Turn some defines into an enum, BALATON Zoltan, 2021/10/27
- [PATCH v3 15/18] hw/sh4/sh_intc: Inline and drop sh_intc_source() function, BALATON Zoltan, 2021/10/27
- [PATCH v3 10/18] hw/intc/sh_intc: Rename iomem region, BALATON Zoltan, 2021/10/27
- [PATCH v3 11/18] hw/intc/sh_intc: Drop another useless macro, BALATON Zoltan, 2021/10/27
- [PATCH v3 03/18] hw/sh4: Change debug printfs to traces, BALATON Zoltan, 2021/10/27