[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 18/18] hw/intc/sh_intc: Simplify allocating sources array
From: |
BALATON Zoltan |
Subject: |
[PATCH v3 18/18] hw/intc/sh_intc: Simplify allocating sources array |
Date: |
Wed, 27 Oct 2021 23:54:31 +0200 |
Use g_new0 instead of g_malloc0 and avoid some unneeded temporary
variable assignments.
Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
---
hw/intc/sh_intc.c | 13 +++----------
1 file changed, 3 insertions(+), 10 deletions(-)
diff --git a/hw/intc/sh_intc.c b/hw/intc/sh_intc.c
index eb58707e83..ed0a5f87cc 100644
--- a/hw/intc/sh_intc.c
+++ b/hw/intc/sh_intc.c
@@ -400,21 +400,14 @@ int sh_intc_init(MemoryRegion *sysmem,
/* Allocate 4 MemoryRegions per register (2 actions * 2 aliases) */
desc->iomem_aliases = g_new0(MemoryRegion,
(nr_mask_regs + nr_prio_regs) * 4);
-
- j = 0;
- i = sizeof(struct intc_source) * nr_sources;
- desc->sources = g_malloc0(i);
-
+ desc->sources = g_new0(struct intc_source, nr_sources);
for (i = 0; i < desc->nr_sources; i++) {
- struct intc_source *source = &desc->sources[i];
-
- source->parent = desc;
+ desc->sources[i].parent = desc;
}
-
desc->irqs = qemu_allocate_irqs(sh_intc_set_irq, desc, nr_sources);
memory_region_init_io(&desc->iomem, NULL, &sh_intc_ops, desc, "intc",
0x100000000ULL);
-
+ j = 0;
if (desc->mask_regs) {
for (i = 0; i < desc->nr_mask_regs; i++) {
struct intc_mask_reg *mr = &desc->mask_regs[i];
--
2.21.4
- Re: [PATCH v3 11/18] hw/intc/sh_intc: Drop another useless macro, (continued)
- [PATCH v3 03/18] hw/sh4: Change debug printfs to traces, BALATON Zoltan, 2021/10/27
- [PATCH v3 08/18] hw/intc/sh_intc: Use existing macro instead of local one, BALATON Zoltan, 2021/10/27
- [PATCH v3 04/18] hw/sh4/r2d: Use error_report instead of fprintf to stderr, BALATON Zoltan, 2021/10/27
- [PATCH v3 12/18] hw/intc/sh_intc: Move sh_intc_register() closer to its only user, BALATON Zoltan, 2021/10/27
- [PATCH v3 16/18] hw/intc/sh_intc: Replace abort() with g_assert_not_reached(), BALATON Zoltan, 2021/10/27
- [PATCH v3 18/18] hw/intc/sh_intc: Simplify allocating sources array,
BALATON Zoltan <=
- [PATCH v3 17/18] hw/intc/sh_intc: Avoid using continue in loops, BALATON Zoltan, 2021/10/27