[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 36/56] tcg/optimize: Split out fold_xx_to_x
From: |
Richard Henderson |
Subject: |
[PULL 36/56] tcg/optimize: Split out fold_xx_to_x |
Date: |
Wed, 27 Oct 2021 19:41:11 -0700 |
Pull the "op r, a, a => mov r, a" optimization into a function,
and use it in the outer opcode fold functions.
Reviewed-by: Luis Pires <luis.pires@eldorado.org.br>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
tcg/optimize.c | 39 ++++++++++++++++++++++++---------------
1 file changed, 24 insertions(+), 15 deletions(-)
diff --git a/tcg/optimize.c b/tcg/optimize.c
index 2f55dc56c0..ab96849edf 100644
--- a/tcg/optimize.c
+++ b/tcg/optimize.c
@@ -704,8 +704,22 @@ static bool fold_xx_to_i(OptContext *ctx, TCGOp *op,
uint64_t i)
return false;
}
+/* If the binary operation has both arguments equal, fold to identity. */
+static bool fold_xx_to_x(OptContext *ctx, TCGOp *op)
+{
+ if (args_are_copies(op->args[1], op->args[2])) {
+ return tcg_opt_gen_mov(ctx, op, op->args[0], op->args[1]);
+ }
+ return false;
+}
+
/*
* These outermost fold_<op> functions are sorted alphabetically.
+ *
+ * The ordering of the transformations should be:
+ * 1) those that produce a constant
+ * 2) those that produce a copy
+ * 3) those that produce information about the result value.
*/
static bool fold_add(OptContext *ctx, TCGOp *op)
@@ -748,7 +762,11 @@ static bool fold_add2_i32(OptContext *ctx, TCGOp *op)
static bool fold_and(OptContext *ctx, TCGOp *op)
{
- return fold_const2(ctx, op);
+ if (fold_const2(ctx, op) ||
+ fold_xx_to_x(ctx, op)) {
+ return true;
+ }
+ return false;
}
static bool fold_andc(OptContext *ctx, TCGOp *op)
@@ -1111,7 +1129,11 @@ static bool fold_not(OptContext *ctx, TCGOp *op)
static bool fold_or(OptContext *ctx, TCGOp *op)
{
- return fold_const2(ctx, op);
+ if (fold_const2(ctx, op) ||
+ fold_xx_to_x(ctx, op)) {
+ return true;
+ }
+ return false;
}
static bool fold_orc(OptContext *ctx, TCGOp *op)
@@ -1747,19 +1769,6 @@ void tcg_optimize(TCGContext *s)
break;
}
- /* Simplify expression for "op r, a, a => mov r, a" cases */
- switch (opc) {
- CASE_OP_32_64_VEC(or):
- CASE_OP_32_64_VEC(and):
- if (args_are_copies(op->args[1], op->args[2])) {
- tcg_opt_gen_mov(&ctx, op, op->args[0], op->args[1]);
- continue;
- }
- break;
- default:
- break;
- }
-
/*
* Process each opcode.
* Sorted alphabetically by opcode as much as possible.
--
2.25.1
- [PULL 16/56] tcg/optimize: Return true from tcg_opt_gen_{mov,movi}, (continued)
- [PULL 16/56] tcg/optimize: Return true from tcg_opt_gen_{mov,movi}, Richard Henderson, 2021/10/27
- [PULL 17/56] tcg/optimize: Split out finish_folding, Richard Henderson, 2021/10/27
- [PULL 25/56] tcg/optimize: Split out fold_mulu2_i32, Richard Henderson, 2021/10/27
- [PULL 19/56] tcg/optimize: Split out fold_mb, fold_qemu_{ld,st}, Richard Henderson, 2021/10/27
- [PULL 20/56] tcg/optimize: Split out fold_const{1,2}, Richard Henderson, 2021/10/27
- [PULL 21/56] tcg/optimize: Split out fold_setcond2, Richard Henderson, 2021/10/27
- [PULL 23/56] tcg/optimize: Split out fold_brcond, Richard Henderson, 2021/10/27
- [PULL 29/56] tcg/optimize: Split out fold_extract, fold_sextract, Richard Henderson, 2021/10/27
- [PULL 33/56] tcg/optimize: Split out fold_dup, fold_dup2, Richard Henderson, 2021/10/27
- [PULL 31/56] tcg/optimize: Split out fold_count_zeros, Richard Henderson, 2021/10/27
- [PULL 36/56] tcg/optimize: Split out fold_xx_to_x,
Richard Henderson <=
- [PULL 38/56] tcg/optimize: Add type to OptContext, Richard Henderson, 2021/10/27
- [PULL 35/56] tcg/optimize: Split out fold_xx_to_i, Richard Henderson, 2021/10/27
- [PULL 24/56] tcg/optimize: Split out fold_setcond, Richard Henderson, 2021/10/27
- [PULL 30/56] tcg/optimize: Split out fold_deposit, Richard Henderson, 2021/10/27
- [PULL 34/56] tcg/optimize: Split out fold_mov, Richard Henderson, 2021/10/27
- [PULL 28/56] tcg/optimize: Split out fold_extract2, Richard Henderson, 2021/10/27
- [PULL 39/56] tcg/optimize: Split out fold_to_not, Richard Henderson, 2021/10/27
- [PULL 08/56] tcg/optimize: Remove do_default label, Richard Henderson, 2021/10/27
- [PULL 22/56] tcg/optimize: Split out fold_brcond2, Richard Henderson, 2021/10/27
- [PULL 26/56] tcg/optimize: Split out fold_addsub2_i32, Richard Henderson, 2021/10/27