[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v4 02/23] hw/char/sh_serial: Use hw_error instead of fprintf and
From: |
BALATON Zoltan |
Subject: |
[PATCH v4 02/23] hw/char/sh_serial: Use hw_error instead of fprintf and abort |
Date: |
Thu, 28 Oct 2021 21:27:05 +0200 |
It does the same with dumping some more state but avoids calling abort
directly and printing to stderr from the device model.
Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
---
hw/char/sh_serial.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/hw/char/sh_serial.c b/hw/char/sh_serial.c
index 1b1e6a6a04..dbefb51d71 100644
--- a/hw/char/sh_serial.c
+++ b/hw/char/sh_serial.c
@@ -26,6 +26,7 @@
*/
#include "qemu/osdep.h"
+#include "hw/hw.h"
#include "hw/irq.h"
#include "hw/sh4/sh.h"
#include "chardev/char-fe.h"
@@ -200,9 +201,7 @@ static void sh_serial_write(void *opaque, hwaddr offs,
}
}
- fprintf(stderr, "sh_serial: unsupported write to 0x%02"
- HWADDR_PRIx "\n", offs);
- abort();
+ hw_error("sh_serial: unsupported write to 0x%02"HWADDR_PRIx"\n", offs);
}
static uint64_t sh_serial_read(void *opaque, hwaddr offs,
@@ -307,9 +306,7 @@ static uint64_t sh_serial_read(void *opaque, hwaddr offs,
#endif
if (ret & ~((1 << 16) - 1)) {
- fprintf(stderr, "sh_serial: unsupported read from 0x%02"
- HWADDR_PRIx "\n", offs);
- abort();
+ hw_error("sh_serial: unsupported read from 0x%02"HWADDR_PRIx"\n",
offs);
}
return ret;
--
2.21.4
- [PATCH v4 00/23] More SH4 clean ups, BALATON Zoltan, 2021/10/28
- [PATCH v4 04/23] hw/sh4/r2d: Use error_report instead of fprintf to stderr, BALATON Zoltan, 2021/10/28
- [PATCH v4 02/23] hw/char/sh_serial: Use hw_error instead of fprintf and abort,
BALATON Zoltan <=
- [PATCH v4 05/23] hw/char/sh_serial: Rename type sh_serial_state to SHSerialState, BALATON Zoltan, 2021/10/28
- [PATCH v4 01/23] hw/sh4: Fix typos in a comment, BALATON Zoltan, 2021/10/28
- [PATCH v4 07/23] hw/char/sh_serial: Add device id to trace output, BALATON Zoltan, 2021/10/28
- [PATCH v4 08/23] hw/intc/sh_intc: Use existing macro instead of local one, BALATON Zoltan, 2021/10/28
- [PATCH v4 10/23] hw/intc/sh_intc: Rename iomem region, BALATON Zoltan, 2021/10/28
- [PATCH v4 03/23] hw/sh4: Change debug printfs to traces, BALATON Zoltan, 2021/10/28