[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 7/9] qapi: Generalize enum member policy checking
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH v2 7/9] qapi: Generalize enum member policy checking |
|
Date: |
Fri, 29 Oct 2021 13:31:40 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 |
On 10/28/21 12:25, Markus Armbruster wrote:
> The code to check enumeration value policy can see special feature
> flag 'deprecated' in QEnumLookup member flags[value]. I want to make
> feature flag 'unstable' visible there as well, so I can add policy for
> it.
>
> Instead of extending flags[], replace it by @special_features (a
> bitset of QapiSpecialFeature), because that's how special features get
> passed around elsewhere.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> Acked-by: John Snow <jsnow@redhat.com>
> ---
> include/qapi/util.h | 5 +----
> qapi/qapi-visit-core.c | 3 ++-
> scripts/qapi/types.py | 22 ++++++++++++----------
> 3 files changed, 15 insertions(+), 15 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
- [PATCH v2 0/9] Configurable policy for handling unstable interfaces, Markus Armbruster, 2021/10/28
- [PATCH v2 4/9] qapi: Tools for sets of special feature flags in generated code, Markus Armbruster, 2021/10/28
- [PATCH v2 3/9] qapi: Eliminate QCO_NO_OPTIONS for a slight simplification, Markus Armbruster, 2021/10/28
- [PATCH v2 7/9] qapi: Generalize enum member policy checking, Markus Armbruster, 2021/10/28
- Re: [PATCH v2 7/9] qapi: Generalize enum member policy checking,
Philippe Mathieu-Daudé <=
- [PATCH v2 5/9] qapi: Generalize struct member policy checking, Markus Armbruster, 2021/10/28
- Re: [PATCH v2 5/9] qapi: Generalize struct member policy checking, Eric Blake, 2021/10/29
[PATCH v2 1/9] qapi: New special feature flag "unstable", Markus Armbruster, 2021/10/28