[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 20/32] target/mips: Convert MSA 3R instruction format to d
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH v3 20/32] target/mips: Convert MSA 3R instruction format to decodetree (part 1/4) |
|
Date: |
Fri, 29 Oct 2021 19:23:31 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 |
On 10/29/21 18:35, Richard Henderson wrote:
> On 10/28/21 2:08 PM, Philippe Mathieu-Daudé wrote:
>> +@3r ...... ... df:2 wt:5ws:5 wd:5 ...... &msa_r
>
> Nit: should this be called @3rf, since it includes df and...
"3R" is how the manual names this instruction class:
Figure 3-40 3R Instruction Format
3R has 2-bit DF field, 3RF has 1-bit DF field. The other
arguments are the same (for the helpers).
>> +TRANS(SLD, trans_msa_3rf, gen_helper_msa_sld_df);
>
> ... you use trans_msa_3rf as the implementation?
Maybe I should name it trans_msa_3r_or_3rf()?
Hmm @3r is actually @3r_df_b (DF=0, DF_BYTE). So trans_msa_3rf()
is a good name for it.
I could rename @3r -> @3r_df_b but then it doesn't match the
manual '3R'. All @3r* use &msa_r structure.
- [PATCH v3 13/32] target/mips: Convert MSA load/store instruction format to decodetree, (continued)
- [PATCH v3 13/32] target/mips: Convert MSA load/store instruction format to decodetree, Philippe Mathieu-Daudé, 2021/10/28
- [PATCH v3 15/32] target/mips: Convert MSA FILL opcode to decodetree, Philippe Mathieu-Daudé, 2021/10/28
- [PATCH v3 14/32] target/mips: Convert MSA 2RF instruction format to decodetree, Philippe Mathieu-Daudé, 2021/10/28
- [PATCH v3 16/32] target/mips: Convert MSA 2R instruction format to decodetree, Philippe Mathieu-Daudé, 2021/10/28
- [PATCH v3 18/32] target/mips: Convert MSA 3RF instruction format to decodetree (DF_HALF), Philippe Mathieu-Daudé, 2021/10/28
- [PATCH v3 17/32] target/mips: Convert MSA VEC instruction format to decodetree, Philippe Mathieu-Daudé, 2021/10/28
- [PATCH v3 19/32] target/mips: Convert MSA 3RF instruction format to decodetree (DF_WORD), Philippe Mathieu-Daudé, 2021/10/28
- [PATCH v3 20/32] target/mips: Convert MSA 3R instruction format to decodetree (part 1/4), Philippe Mathieu-Daudé, 2021/10/28
- [PATCH v3 21/32] target/mips: Convert MSA 3R instruction format to decodetree (part 2/4), Philippe Mathieu-Daudé, 2021/10/28
- [PATCH v3 22/32] target/mips: Convert MSA 3R instruction format to decodetree (part 3/4), Philippe Mathieu-Daudé, 2021/10/28
- [PATCH v3 24/32] target/mips: Convert MSA ELM instruction format to decodetree, Philippe Mathieu-Daudé, 2021/10/28
- [PATCH v3 23/32] target/mips: Convert MSA 3R instruction format to decodetree (part 4/4), Philippe Mathieu-Daudé, 2021/10/28
- [PATCH v3 25/32] target/mips: Convert MSA COPY_U opcode to decodetree, Philippe Mathieu-Daudé, 2021/10/28
- [PATCH v3 26/32] target/mips: Convert MSA COPY_S and INSERT opcodes to decodetree, Philippe Mathieu-Daudé, 2021/10/28
- [PATCH v3 27/32] target/mips: Convert MSA MOVE.V opcode to decodetree, Philippe Mathieu-Daudé, 2021/10/28