[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 4/9] qapi: Tools for sets of special feature flags in generated co
From: |
Markus Armbruster |
Subject: |
[PULL 4/9] qapi: Tools for sets of special feature flags in generated code |
Date: |
Fri, 29 Oct 2021 21:30:10 +0200 |
New enum QapiSpecialFeature enumerates the special feature flags.
New helper gen_special_features() returns code to represent a
collection of special feature flags as a bitset.
The next few commits will put them to use.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: John Snow <jsnow@redhat.com>
Message-Id: <20211028102520.747396-5-armbru@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
include/qapi/util.h | 4 ++++
scripts/qapi/gen.py | 8 ++++++++
scripts/qapi/schema.py | 3 +++
3 files changed, 15 insertions(+)
diff --git a/include/qapi/util.h b/include/qapi/util.h
index 257c600f99..7a8d5c7d72 100644
--- a/include/qapi/util.h
+++ b/include/qapi/util.h
@@ -11,6 +11,10 @@
#ifndef QAPI_UTIL_H
#define QAPI_UTIL_H
+typedef enum {
+ QAPI_DEPRECATED,
+} QapiSpecialFeature;
+
/* QEnumLookup flags */
#define QAPI_ENUM_DEPRECATED 1
diff --git a/scripts/qapi/gen.py b/scripts/qapi/gen.py
index 2ec1e7b3b6..995a97d2b8 100644
--- a/scripts/qapi/gen.py
+++ b/scripts/qapi/gen.py
@@ -18,6 +18,7 @@
Dict,
Iterator,
Optional,
+ Sequence,
Tuple,
)
@@ -29,6 +30,7 @@
mcgen,
)
from .schema import (
+ QAPISchemaFeature,
QAPISchemaIfCond,
QAPISchemaModule,
QAPISchemaObjectType,
@@ -37,6 +39,12 @@
from .source import QAPISourceInfo
+def gen_special_features(features: Sequence[QAPISchemaFeature]) -> str:
+ special_features = [f"1u << QAPI_{feat.name.upper()}"
+ for feat in features if feat.is_special()]
+ return ' | '.join(special_features) or '0'
+
+
class QAPIGen:
def __init__(self, fname: str):
self.fname = fname
diff --git a/scripts/qapi/schema.py b/scripts/qapi/schema.py
index 6d5f46509a..55f82d7389 100644
--- a/scripts/qapi/schema.py
+++ b/scripts/qapi/schema.py
@@ -725,6 +725,9 @@ def connect_doc(self, doc):
class QAPISchemaFeature(QAPISchemaMember):
role = 'feature'
+ def is_special(self):
+ return self.name in ('deprecated')
+
class QAPISchemaObjectTypeMember(QAPISchemaMember):
def __init__(self, name, info, typ, optional, ifcond=None, features=None):
--
2.31.1
- [PULL 0/9] QAPI patches patches for 2021-10-29, Markus Armbruster, 2021/10/29
- [PULL 7/9] qapi: Generalize enum member policy checking, Markus Armbruster, 2021/10/29
- [PULL 3/9] qapi: Eliminate QCO_NO_OPTIONS for a slight simplification, Markus Armbruster, 2021/10/29
- [PULL 8/9] qapi: Factor out compat_policy_input_ok(), Markus Armbruster, 2021/10/29
- [PULL 1/9] qapi: New special feature flag "unstable", Markus Armbruster, 2021/10/29
- [PULL 5/9] qapi: Generalize struct member policy checking, Markus Armbruster, 2021/10/29
- [PULL 9/9] qapi: Extend -compat to set policy for unstable interfaces, Markus Armbruster, 2021/10/29
- [PULL 2/9] qapi: Mark unstable QMP parts with feature 'unstable', Markus Armbruster, 2021/10/29
- [PULL 4/9] qapi: Tools for sets of special feature flags in generated code,
Markus Armbruster <=
- [PULL 6/9] qapi: Generalize command policy checking, Markus Armbruster, 2021/10/29
- Re: [PULL 0/9] QAPI patches patches for 2021-10-29, Richard Henderson, 2021/10/30