[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 0/3] Dynamic sysbus device check error report
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH v3 0/3] Dynamic sysbus device check error report |
|
Date: |
Fri, 29 Oct 2021 22:00:40 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 |
On 10/29/21 16:22, Damien Hedde wrote:
> Hi,
>
> Dynamic sysbus devices are allowed by a per-machine basis.
> Right now, the allowance check is done during an machine_init_done
> notifier, well after such devices are created.
>
> This series move the check at the right place (during the handling
> of a QMP device_add command or -device CLI option) so that we can
> report the error right away.
>
> This was initially part of my RFC (hence the v3) about allowing to
> create devices during the machine initialized phase (link is below).
> But it seems to me these patches make sense already as a standalone
> cleanup.
LGTM but I'd like an Ack from Eduardo or Marcel.