[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v6 58/66] accel/tcg: Report unaligned load/store for user-only
From: |
Richard Henderson |
Subject: |
[PATCH v6 58/66] accel/tcg: Report unaligned load/store for user-only |
Date: |
Sat, 30 Oct 2021 10:16:27 -0700 |
Use the new cpu_loop_exit_sigbus for cpu_mmu_lookup.
Reviewed-by: Warner Losh <imp@bsdimp.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
accel/tcg/user-exec.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/accel/tcg/user-exec.c b/accel/tcg/user-exec.c
index 1ee64f01fc..aaf47d89d2 100644
--- a/accel/tcg/user-exec.c
+++ b/accel/tcg/user-exec.c
@@ -218,9 +218,14 @@ static void validate_memop(MemOpIdx oi, MemOp expected)
static void *cpu_mmu_lookup(CPUArchState *env, target_ulong addr,
MemOpIdx oi, uintptr_t ra, MMUAccessType type)
{
+ MemOp mop = get_memop(oi);
+ int a_bits = get_alignment_bits(mop);
void *ret;
- /* TODO: Enforce guest required alignment. */
+ /* Enforce guest required alignment. */
+ if (unlikely(addr & ((1 << a_bits) - 1))) {
+ cpu_loop_exit_sigbus(env_cpu(env), addr, type, ra);
+ }
ret = g2h(env_cpu(env), addr);
set_helper_retaddr(ra);
--
2.25.1
- [PATCH v6 49/66] target/ppc: Set fault address in ppc_cpu_do_unaligned_access, (continued)
- [PATCH v6 49/66] target/ppc: Set fault address in ppc_cpu_do_unaligned_access, Richard Henderson, 2021/10/30
- [PATCH v6 59/66] tcg: Add helper_unaligned_{ld, st} for user-only sigbus, Richard Henderson, 2021/10/30
- [PATCH v6 57/66] accel/tcg: Report unaligned atomics for user-only, Richard Henderson, 2021/10/30
- [PATCH v6 60/66] linux-user: Handle BUS_ADRALN in host_signal_handler, Richard Henderson, 2021/10/30
- [PATCH v6 56/66] target/sparc: Set fault address in sparc_cpu_do_unaligned_access, Richard Henderson, 2021/10/30
- [PATCH v6 62/66] linux-user: Disable more prctl subcodes, Richard Henderson, 2021/10/30
- [PATCH v6 54/66] target/sparc: Remove DEBUG_UNALIGNED, Richard Henderson, 2021/10/30
- [PATCH v6 53/66] target/sh4: Set fault address in superh_cpu_do_unaligned_access, Richard Henderson, 2021/10/30
- [PATCH v6 65/66] target/hppa: Implement prctl_unalign_sigbus, Richard Henderson, 2021/10/30
- [PATCH v6 48/66] target/ppc: Move SPR_DSISR setting to powerpc_excp, Richard Henderson, 2021/10/30
- [PATCH v6 58/66] accel/tcg: Report unaligned load/store for user-only,
Richard Henderson <=
- [PATCH v6 63/66] linux-user: Add code for PR_GET/SET_UNALIGN, Richard Henderson, 2021/10/30
- [PATCH v6 47/66] target/microblaze: Do not set MO_ALIGN for user-only, Richard Henderson, 2021/10/30
- [PATCH v6 55/66] target/sparc: Split out build_sfsr, Richard Henderson, 2021/10/30
- [PATCH v6 61/66] linux-user: Split out do_prctl and subroutines, Richard Henderson, 2021/10/30
- [PATCH v6 64/66] target/alpha: Implement prctl_unalign_sigbus, Richard Henderson, 2021/10/30
- [PATCH v6 66/66] target/sh4: Implement prctl_unalign_sigbus, Richard Henderson, 2021/10/30
- Re: [PATCH v6 00/66] user-only: Cleanup SIGSEGV and SIGBUS handling, Philippe Mathieu-Daudé, 2021/10/31