Re: [PULL 21/26] configure, meson: move more compiler checks to Meson

[Peter Maydell]

On Mon, 15 Nov 2021 at 16:42, Peter Maydell <peter.maydell@linaro.org> wrote:
>
> On Mon, 15 Nov 2021 at 16:36, Peter Maydell <peter.maydell@linaro.org> wrote:
> >
> > On Thu, 14 Oct 2021 at 17:49, Paolo Bonzini <pbonzini@redhat.com> wrote:
> > > +config_host_data.set('CONFIG_IOVEC',
> > > +                     cc.has_header_symbol('sys/uio.h', 'struct iovec'))

> https://github.com/mesonbuild/meson/issues/1975 says that for gcc
> it's actually going to be wrong the other way (always setting CONFIG_IOVEC
> whether the system header has the struct or not), because "struct wombat;"
> is syntactically OK as a *declaration*, not a use.

In case anybody's interested in an easy-ish meson contribution,
meson upstream indicated in that issue that they'd be open to a patch
which made whitespace in the has_header_symbol argument be an error,
which would have caught this bug earlier.

-- PMM