Re: [PATCH v1 25/34] linux-user/elfload: add extra logging for hole finding

[Philippe Mathieu-Daudé]

On 1/5/22 14:50, Alex Bennée wrote:
> The various approaches to finding memory holes are quite complicated
> to follow especially at a distance. Improve the logging so we can see
> exactly what method found the space for the guest memory.
> 
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
>  linux-user/elfload.c | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)

> @@ -2391,6 +2403,9 @@ static void pgb_static(const char *image_name, 
> abi_ulong orig_loaddr,
>      }
>  
>      guest_base = addr;
> +
> +    qemu_log_mask(CPU_LOG_PAGE, "%s: base @ %"PRIxPTR" for %" PRIdPTR" 
> bytes\n",
> +                  __func__, addr, hiaddr - loaddr);

TIL PRIxPTR / PRIdPTR!

>  }
>  
>  static void pgb_dynamic(const char *image_name, long align)
> @@ -2447,6 +2462,9 @@ static void pgb_reserved_va(const char *image_name, 
> abi_ulong guest_loaddr,
>                       "using -R option)", reserved_va, test, strerror(errno));
>          exit(EXIT_FAILURE);
>      }
> +
> +    qemu_log_mask(CPU_LOG_PAGE, "%s: base @ %p for %ld bytes\n",

"for %lu bytes", otherwise:
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

> +                  __func__, addr, reserved_va);
>  }
>  
>  void probe_guest_base(const char *image_name, abi_ulong guest_loaddr,