[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v4 03/23] migration: ram_release_pages() always receive 1 page as
From: |
Juan Quintela |
Subject: |
[PATCH v4 03/23] migration: ram_release_pages() always receive 1 page as argument |
Date: |
Tue, 11 Jan 2022 14:00:04 +0100 |
Remove the pages argument. And s/pages/page/
Signed-off-by: Juan Quintela <quintela@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
--
- Use 1LL instead of casts (philmd)
- Change the whole 1ULL for TARGET_PAGE_SIZE
Signed-off-by: Juan Quintela <quintela@redhat.com>
---
migration/ram.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/migration/ram.c b/migration/ram.c
index 7223b0d8ca..881fe4974e 100644
--- a/migration/ram.c
+++ b/migration/ram.c
@@ -1204,13 +1204,13 @@ static int save_zero_page(RAMState *rs, RAMBlock
*block, ram_addr_t offset)
return -1;
}
-static void ram_release_pages(const char *rbname, uint64_t offset, int pages)
+static void ram_release_page(const char *rbname, uint64_t offset)
{
if (!migrate_release_ram() || !migration_in_postcopy()) {
return;
}
- ram_discard_range(rbname, offset, ((ram_addr_t)pages) << TARGET_PAGE_BITS);
+ ram_discard_range(rbname, offset, TARGET_PAGE_SIZE);
}
/*
@@ -1365,7 +1365,7 @@ static bool do_compress_ram_page(QEMUFile *f, z_stream
*stream, RAMBlock *block,
}
exit:
- ram_release_pages(block->idstr, offset & TARGET_PAGE_MASK, 1);
+ ram_release_page(block->idstr, offset & TARGET_PAGE_MASK);
return zero_page;
}
@@ -2153,7 +2153,7 @@ static int ram_save_target_page(RAMState *rs,
PageSearchStatus *pss)
xbzrle_cache_zero_page(rs, block->offset + offset);
XBZRLE_cache_unlock();
}
- ram_release_pages(block->idstr, offset, res);
+ ram_release_page(block->idstr, offset);
return res;
}
--
2.34.1
- [PATCH v4 00/23] Migration: Transmit and detect zero pages in the multifd threads, Juan Quintela, 2022/01/11
- [PATCH v4 01/23] migration: All this fields are unsigned, Juan Quintela, 2022/01/11
- [PATCH v4 03/23] migration: ram_release_pages() always receive 1 page as argument,
Juan Quintela <=
- [PATCH v4 04/23] migration: Remove masking for compression, Juan Quintela, 2022/01/11
- [PATCH v4 02/23] migration: We only need last_stage in two places, Juan Quintela, 2022/01/11
- [PATCH v4 09/23] multifd: Make zlib use iov's, Juan Quintela, 2022/01/11
- [PATCH v4 05/23] migration: simplify do_compress_ram_page, Juan Quintela, 2022/01/11
- [PATCH v4 10/23] multifd: Make zstd use iov's, Juan Quintela, 2022/01/11
- [PATCH v4 07/23] multifd: Use proper maximum compression values, Juan Quintela, 2022/01/11
- [PATCH v4 08/23] multifd: Move iov from pages to params, Juan Quintela, 2022/01/11