[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] drop libxml2 checks since libxml is not actually used (for p
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [PATCH] drop libxml2 checks since libxml is not actually used (for parallels) |
|
Date: |
Wed, 19 Jan 2022 17:07:09 +0000 |
On Wed, Jan 19, 2022 at 12:04:23PM +0300, Michael Tokarev wrote:
> [This is a trivial patch, but due to the number of files it touches
> I'm not using qemu-trivial@ route.]
>
> For a long time, we assumed that libxml2 is neecessary for parallels
> block format support (block/parallels*). However, this format actually
> does not use libxml. Since this is the only user of libxml2 in while
> qemu tree, we can drop all libxml2 checks and dependencies too.
>
> It is even more: --enable-parallels configure option was the only
> option which was silently ignored when it's (fake) dependency
> (libxml2) isn't installed.
>
> Drop all mentions of libxml2.
>
> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
> ---
> .cirrus.yml | 1 -
> .gitlab-ci.d/cirrus/freebsd-12.vars | 2 +-
> .gitlab-ci.d/cirrus/freebsd-13.vars | 2 +-
> .gitlab-ci.d/cirrus/macos-11.vars | 2 +-
> .gitlab-ci.d/windows.yml | 2 --
> block/meson.build | 3 +--
> meson.build | 6 ------
> meson_options.txt | 2 --
> scripts/ci/org.centos/stream/8/x86_64/configure | 1 -
> scripts/coverity-scan/coverity-scan.docker | 1 -
> scripts/coverity-scan/run-coverity-scan | 2 +-
> tests/docker/dockerfiles/alpine.docker | 1 -
> tests/docker/dockerfiles/centos8.docker | 1 -
> tests/docker/dockerfiles/fedora.docker | 1 -
> tests/docker/dockerfiles/opensuse-leap.docker | 1 -
> tests/docker/dockerfiles/ubuntu1804.docker | 1 -
> tests/docker/dockerfiles/ubuntu2004.docker | 1 -
> 17 files changed, 5 insertions(+), 25 deletions(-)
Nice cleanup.
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
signature.asc
Description: PGP signature