Re: [PATCH v2 4/6] drop libxml2 checks since libxml is not actually used (for parallels)

[Philippe Mathieu-Daudé]

On 20/1/22 14:37, Thomas Huth wrote:
> On 20/01/2022 12.05, Philippe Mathieu-Daudé wrote:
> > From: Michael Tokarev <mjt@tls.msk.ru>
> >
> > For a long time, we assumed that libxml2 is neecessary for parallels

Also "necessary",

> > block format support (block/parallels*). However, this format actually
> > does not use libxml [*]. Since this is the only user of libxml2 in
> > while qemu tree, we can drop all libxml2 checks and dependencies too.

and eventually "QEMU".

> s/while/whole/
>
> > It is even more: --enable-parallels configure option was the only
> > option which was silently ignored when it's (fake) dependency
> > (libxml2) isn't installed.
> >
> > Drop all mentions of libxml2.
> >
> > [*] Actually the basis for libxml use were merged in commit 25bfd5a75
> >      but the implementation was never merged:
> >      
> > 70227bbd-a517-70e9-714f-e6e0ec431be9@openvz.org/">https://lore.kernel.org/qemu-devel/70227bbd-a517-70e9-714f-e6e0ec431be9@openvz.org/ 
>
> Commit ed279a06c53784 also add a hunk to scripts/checkpatch.pl ... you 
> might want to remove that now, too.

Good catch!