[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 1/7] scripts/qapi/gen.py: add FOO.trace-events output modu
From: |
Stefan Hajnoczi |
Subject: |
Re: [PATCH v5 1/7] scripts/qapi/gen.py: add FOO.trace-events output module |
Date: |
Wed, 26 Jan 2022 13:20:10 +0000 |
On Tue, Jan 25, 2022 at 10:56:49PM +0100, Vladimir Sementsov-Ogievskiy wrote:
> @@ -264,6 +272,14 @@ def _genh(self) -> QAPIGenH:
> assert self._current_module is not None
> return self._module[self._current_module][1]
>
> + @property
> + def _gent(self) -> QAPIGenTrace:
If you respin maybe rename this to _gentrace() or even
_gen_trace_events() so the name is clearer (although the latter collides
with the self._gen_trace_events field and may need to be renamed to
enable_trace_events or similar).
signature.asc
Description: PGP signature
- [PATCH v5 0/7] trace qmp commands, Vladimir Sementsov-Ogievskiy, 2022/01/25
- [PATCH v5 6/7] meson: document, why we don't generate trace events for tests/ and qga/, Vladimir Sementsov-Ogievskiy, 2022/01/25
- [PATCH v5 1/7] scripts/qapi/gen.py: add FOO.trace-events output module, Vladimir Sementsov-Ogievskiy, 2022/01/25
- [PATCH v5 5/7] docs/qapi-code-gen: update to cover trace events code generation, Vladimir Sementsov-Ogievskiy, 2022/01/25
- [PATCH v5 7/7] qapi: generate trace events by default, Vladimir Sementsov-Ogievskiy, 2022/01/25
- [PATCH v5 2/7] qapi/commands: refactor error handling code, Vladimir Sementsov-Ogievskiy, 2022/01/25
- [PATCH v5 3/7] qapi/commands: Optionally generate trace for QMP commands, Vladimir Sementsov-Ogievskiy, 2022/01/25
- [PATCH v5 4/7] meson: generate trace events for qmp commands, Vladimir Sementsov-Ogievskiy, 2022/01/25