[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 14/14] qapi: fix example of dump-guest-memory
From: |
Markus Armbruster |
Subject: |
Re: [PATCH v3 14/14] qapi: fix example of dump-guest-memory |
Date: |
Tue, 29 Mar 2022 17:56:22 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) |
Victor Toso <victortoso@redhat.com> writes:
> Example output lacks mandatory member @paging. Provide it.
>
> Signed-off-by: Victor Toso <victortoso@redhat.com>
> Reviewed-by: John Snow <jsnow@redhat.com>
> ---
> qapi/dump.json | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/qapi/dump.json b/qapi/dump.json
> index 9119c82b14..29441af9d8 100644
> --- a/qapi/dump.json
> +++ b/qapi/dump.json
> @@ -83,7 +83,7 @@
> # Example:
> #
> # -> { "execute": "dump-guest-memory",
> -# "arguments": { "protocol": "fd:dump" } }
> +# "arguments": { "paging": false, "protocol": "fd:dump" } }
> # <- { "return": {} }
> #
> ##
Reviewed-by: Markus Armbruster <armbru@redhat.com>
- [PATCH v3 10/14] qapi: run-state examples: add missing @timestamp, (continued)
- [PATCH v3 10/14] qapi: run-state examples: add missing @timestamp, Victor Toso, 2022/03/28
- [PATCH v3 11/14] qapi: fix example of MEMORY_FAILURE, Victor Toso, 2022/03/28
- [PATCH v3 12/14] qapi: ui examples: add missing @websocket member, Victor Toso, 2022/03/28
- [PATCH v3 13/14] qapi: fix example of ACPI_DEVICE_OST event, Victor Toso, 2022/03/28
- [PATCH v3 14/14] qapi: fix example of dump-guest-memory, Victor Toso, 2022/03/28
- Re: [PATCH v3 14/14] qapi: fix example of dump-guest-memory,
Markus Armbruster <=
- Re: [PATCH v3 00/14] Fix some qapi examples and a TODO section, Markus Armbruster, 2022/03/29
- Re: [PATCH v3 00/14] Fix some qapi examples and a TODO section, Markus Armbruster, 2022/03/31