qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3] ui/cocoa: Take refresh rate into account


From: Gerd Hoffmann
Subject: Re: [PATCH v3] ui/cocoa: Take refresh rate into account
Date: Fri, 1 Jul 2022 12:10:55 +0200

On Tue, Jun 21, 2022 at 09:51:38AM +0100, Peter Maydell wrote:
> On Mon, 20 Jun 2022 at 21:29, Akihiko Odaki <akihiko.odaki@gmail.com> wrote:
> >
> > Retreieve the refresh rate of the display and reflect it with
> > dpy_set_ui_info() and update_displaychangelistener(), allowing the
> > guest and DisplayChangeListener to consume the information.
> 
> But why? What goes wrong if we don't bother to do this?

Nothing goes wrong.  This provides a hint to the guest how often the
display is updated, so the guest has the chance to adapt to that.
When we run 30 Hz display updates on the host side it is pointless for
the guest to update the screen at 60Hz frequency, the guest can spare
some cpu cycles instead.

[ this should be better explained in the commit message ]

take care,
  Gerd




reply via email to

[Prev in Thread] Current Thread [Next in Thread]