[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 3/3] hw/cxl: Fix size of constant in interleave granularity funct
From: |
Jonathan Cameron |
Subject: |
[PATCH 3/3] hw/cxl: Fix size of constant in interleave granularity function. |
Date: |
Fri, 1 Jul 2022 14:23:00 +0100 |
Whilst the interleave granularity is always small enough that this isn't
a real problem (much less than 4GiB) let's change the constant
to ULL to fix the coverity warning.
Reported-by: Peter Maydell <peter.maydell@linaro.org>
Fixes: 829de299d1 ("hw/cxl/component: Add utils for interleave parameter
encoding/decoding")
Fixes: Coverity CID 1488868
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
---
include/hw/cxl/cxl_component.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/hw/cxl/cxl_component.h b/include/hw/cxl/cxl_component.h
index 70b5018156..94ec2f07d7 100644
--- a/include/hw/cxl/cxl_component.h
+++ b/include/hw/cxl/cxl_component.h
@@ -215,7 +215,7 @@ uint8_t cxl_interleave_granularity_enc(uint64_t gran, Error
**errp);
static inline hwaddr cxl_decode_ig(int ig)
{
- return 1 << (ig + 8);
+ return 1ULL << (ig + 8);
}
CXLComponentState *cxl_get_hb_cstate(PCIHostState *hb);
--
2.32.0
- [PATCH 0/3] hw/cxl, hw/machine, hw/i386: Misc minor fixes / cleanup, Jonathan Cameron, 2022/07/01
- [PATCH 1/3] hw/machine: Clear out left over CXL related pointer from move of state handling to machines., Jonathan Cameron, 2022/07/01
- [PATCH 2/3] hw/i386/pc: Always place CXL Memory Regions after device_memory, Jonathan Cameron, 2022/07/01
- [PATCH 3/3] hw/cxl: Fix size of constant in interleave granularity function.,
Jonathan Cameron <=
- Re: [PATCH 0/3] hw/cxl, hw/machine, hw/i386: Misc minor fixes / cleanup, Igor Mammedov, 2022/07/11
- Re: [PATCH 0/3] hw/cxl, hw/machine, hw/i386: Misc minor fixes / cleanup, Peter Maydell, 2022/07/19