[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 12/17] x86: pci: acpi: reorder Device's _ADR and _SUN fields
From: |
Igor Mammedov |
Subject: |
[PATCH 12/17] x86: pci: acpi: reorder Device's _ADR and _SUN fields |
Date: |
Fri, 1 Jul 2022 09:35:10 -0400 |
no functional change, align order of fields in empty slot
descriptor with a populated slot ordering.
Expected diff:
- Name (_SUN, 0x0X) // _SUN: Slot User Number
Name (_ADR, 0xY) // _ADR: Address
...
+ Name (_SUN, 0xX) // _SUN: Slot User Number
that will eliminate contextual changes (causing test failures)
when follow up patches merge code generating populated and empty
slots descriptors.
Put mandatory _ADR as the 1st field, then ASUN as it can be
present for both pupulated and empty slots and only then _SUN
which is present only when slot is hotpluggable.
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
---
hw/i386/acpi-build.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
index 36fe43c52f..fd7f3253e5 100644
--- a/hw/i386/acpi-build.c
+++ b/hw/i386/acpi-build.c
@@ -442,8 +442,8 @@ static void build_append_pci_bus_devices(Aml *parent_scope,
PCIBus *bus,
break;
}
dev = aml_device("S%.02X", devfn);
- aml_append(dev, aml_name_decl("ASUN", aml_int(slot)));
aml_append(dev, aml_name_decl("_ADR", aml_int(adr)));
+ aml_append(dev, aml_name_decl("ASUN", aml_int(slot)));
aml_append(dev, aml_name_decl("_SUN", aml_int(slot)));
method = aml_method("_EJ0", 1, AML_NOTSERIALIZED);
aml_append(method,
--
2.31.1
- Re: [PATCH 02/17] acpi: x86: deduplicate HPET AML building, (continued)
[PATCH 01/17] tests: acpi: whitelist pc/q35 DSDT due to HPET AML move, Igor Mammedov, 2022/07/01
[PATCH 11/17] tests: acpi: whitelist pc/q35 DSDT before moving _ADR field, Igor Mammedov, 2022/07/01
[PATCH 17/17] x86: pci: acpi: deduplate PCI slots creation, Igor Mammedov, 2022/07/01
[PATCH 06/17] x86: acpi: _DSM: use Package to pass parameters, Igor Mammedov, 2022/07/01
[PATCH 15/17] x86: pci: acpi: reorder Device's _DSM method, Igor Mammedov, 2022/07/01
[PATCH 16/17] tests: acpi: update expected blobs, Igor Mammedov, 2022/07/01
[PATCH 05/17] acpi: x86: refactor PDSM method to reduce nesting, Igor Mammedov, 2022/07/01
[PATCH 14/17] tests: acpi: whitelist pc/q35 DSDT before moving _ADR field, Igor Mammedov, 2022/07/01
[PATCH 12/17] x86: pci: acpi: reorder Device's _ADR and _SUN fields,
Igor Mammedov <=
[PATCH 13/17] tests: acpi: update expected blobs, Igor Mammedov, 2022/07/01
[PATCH 09/17] x86: acpi: cleanup PCI device _DSM duplication, Igor Mammedov, 2022/07/01