[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 23/23] target/loongarch: Add lock when writing timer clear reg
From: |
Richard Henderson |
Subject: |
[PULL 23/23] target/loongarch: Add lock when writing timer clear reg |
Date: |
Mon, 4 Jul 2022 15:03:57 +0530 |
From: Xiaojuan Yang <yangxiaojuan@loongson.cn>
There is such error info when running linux kernel:
tcg_handle_interrupt: assertion failed: (qemu_mutex_iothread_locked()).
calling stack:
#0 in raise () at /lib64/libc.so.6
#1 in abort () at /lib64/libc.so.6
#2 in g_assertion_message_expr.cold () at /lib64/libglib-2.0.so.0
#3 in g_assertion_message_expr () at /lib64/libglib-2.0.so.0
#4 in tcg_handle_interrupt (cpu=0x632000030800, mask=2) at
../accel/tcg/tcg-accel-ops.c:79
#5 in cpu_interrupt (cpu=0x632000030800, mask=2) at ../softmmu/cpus.c:248
#6 in loongarch_cpu_set_irq (opaque=0x632000030800, irq=11, level=0)
at ../target/loongarch/cpu.c:100
#7 in helper_csrwr_ticlr (env=0x632000039440, val=1) at
../target/loongarch/csr_helper.c:85
#8 in code_gen_buffer ()
#9 in cpu_tb_exec (cpu=0x632000030800, itb=0x7fff946ac280,
tb_exit=0x7ffe4fcb6c30)
at ../accel/tcg/cpu-exec.c:358
Add mutex iothread lock around loongarch_cpu_set_irq in csrwr_ticlr() to
fix the bug.
Signed-off-by: Xiaojuan Yang <yangxiaojuan@loongson.cn>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20220701093407.2150607-10-yangxiaojuan@loongson.cn>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/loongarch/csr_helper.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/target/loongarch/csr_helper.c b/target/loongarch/csr_helper.c
index 24a9389364..7e02787895 100644
--- a/target/loongarch/csr_helper.c
+++ b/target/loongarch/csr_helper.c
@@ -81,7 +81,9 @@ target_ulong helper_csrwr_ticlr(CPULoongArchState *env,
target_ulong val)
int64_t old_v = 0;
if (val & 0x1) {
+ qemu_mutex_lock_iothread();
loongarch_cpu_set_irq(cpu, IRQ_TIMER, 0);
+ qemu_mutex_unlock_iothread();
}
return old_v;
}
--
2.34.1
- [PULL 14/23] hw/intc/loongarch_pch_msi: Fix msi vector convertion, (continued)
- [PULL 14/23] hw/intc/loongarch_pch_msi: Fix msi vector convertion, Richard Henderson, 2022/07/04
- [PULL 13/23] target/loongarch: Update README, Richard Henderson, 2022/07/04
- [PULL 15/23] hw/rtc/ls7a_rtc: Fix uninitialied bugs and toymatch writing function, Richard Henderson, 2022/07/04
- [PULL 16/23] hw/rtc/ls7a_rtc: Fix timer call back function, Richard Henderson, 2022/07/04
- [PULL 17/23] hw/rtc/ls7a_rtc: Remove unimplemented device in realized function, Richard Henderson, 2022/07/04
- [PULL 18/23] hw/rtc/ls7a_rtc: Add reset function, Richard Henderson, 2022/07/04
- [PULL 19/23] hw/rtc/ls7a_rtc: Fix rtc enable and disable function, Richard Henderson, 2022/07/04
- [PULL 20/23] hw/rtc/ls7a_rtc: Use tm struct pointer as arguments in toy_time_to_val(), Richard Henderson, 2022/07/04
- [PULL 21/23] hw/rtc/ls7a_rtc: Fix 'calculate' spelling errors, Richard Henderson, 2022/07/04
- [PULL 22/23] target/loongarch: Fix the meaning of ECFG reg's VS field, Richard Henderson, 2022/07/04
- [PULL 23/23] target/loongarch: Add lock when writing timer clear reg,
Richard Henderson <=
- Re: [PULL 00/23] loongarch64 patch queue, Richard Henderson, 2022/07/04