[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 2/3] Add zero-copy-copied migration stat
From: |
Daniel P . Berrangé |
Subject: |
Re: [PATCH v2 2/3] Add zero-copy-copied migration stat |
Date: |
Mon, 4 Jul 2022 14:14:22 +0100 |
User-agent: |
Mutt/2.2.6 (2022-06-05) |
On Mon, Jul 04, 2022 at 02:59:50PM +0200, Markus Armbruster wrote:
> Daniel P. Berrangé <berrange@redhat.com> writes:
>
> > On Mon, Jul 04, 2022 at 02:04:41PM +0200, Markus Armbruster wrote:
>
> [...]
>
> >> Please rephrase the documentation of @zero-copy-copied in terms of
> >> @dirty-sync-count. Here's my attempt.
> >>
> >> # @zero-copy-copied: Number of times dirty RAM synchronization could not
> >> # avoid copying zero pages. This is between 0 and
> >> # @dirty-sync-count. (since 7.1)
> >
> > Any one have preferences on the name - i get slight put off by the
> > repeated word in the property name here.
> >
> > @zero-copy-rejects ?
> > @zero-copy-misses ?
> > @zero-copy-fails ?
>
> I'd consider any of these an improvement. Not a native speaker, but
> perhaps "failures" instead of "fails".
>
> We could also express the connection to @dirty-sync-count right in the
> name, like @dirty-sync-rejected-zero-copy, @dirty-sync-missed-zero-copy,
> @dirty-sync-failed-zero-copy. Or maybe -copies.
Yeah, @dirty-sync-missed-zero-copy is probably my favourite.
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- [PATCH v2 0/3] Zero copy improvements (QIOChannel + multifd), Leonardo Bras, 2022/07/01
- [PATCH v2 1/3] QIOChannelSocket: Fix zero-copy flush returning code 1 when nothing sent, Leonardo Bras, 2022/07/01
- [PATCH v2 2/3] Add zero-copy-copied migration stat, Leonardo Bras, 2022/07/01
- Re: [PATCH v2 2/3] Add zero-copy-copied migration stat, Markus Armbruster, 2022/07/04
- Re: [PATCH v2 2/3] Add zero-copy-copied migration stat, Daniel P . Berrangé, 2022/07/04
- Re: [PATCH v2 2/3] Add zero-copy-copied migration stat, Markus Armbruster, 2022/07/04
- Re: [PATCH v2 2/3] Add zero-copy-copied migration stat, Dr. David Alan Gilbert, 2022/07/04
- Re: [PATCH v2 2/3] Add zero-copy-copied migration stat, Markus Armbruster, 2022/07/04
- Re: [PATCH v2 2/3] Add zero-copy-copied migration stat, Daniel P . Berrangé, 2022/07/04
- Re: [PATCH v2 2/3] Add zero-copy-copied migration stat, Markus Armbruster, 2022/07/04
- Re: [PATCH v2 2/3] Add zero-copy-copied migration stat,
Daniel P . Berrangé <=
- Re: [PATCH v2 2/3] Add zero-copy-copied migration stat, Leonardo Brás, 2022/07/04
- Re: [PATCH v2 2/3] Add zero-copy-copied migration stat, Markus Armbruster, 2022/07/05
[PATCH v2 3/3] migration/multifd: Warn user when zerocopy not working, Leonardo Bras, 2022/07/01