[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 4/7] misc: fix commonly doubled up words
From: |
Peter Maydell |
Subject: |
Re: [PATCH v2 4/7] misc: fix commonly doubled up words |
Date: |
Mon, 4 Jul 2022 16:52:40 +0100 |
On Mon, 4 Jul 2022 at 16:23, Daniel P. Berrangé <berrange@redhat.com> wrote:
>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
> --- a/docs/tools/qemu-pr-helper.rst
> +++ b/docs/tools/qemu-pr-helper.rst
> @@ -22,7 +22,7 @@ storage fabric. QEMU's SCSI passthrough devices
> ``scsi-block``
> and ``scsi-generic`` support passing guest persistent reservation
> requests to a privileged external helper program. :program:`qemu-pr-helper`
> is that external helper; it creates a socket which QEMU can
> -connect to to communicate with it.
> +connect to communicate with it.
This text is correct as it stands, and the change is wrong.
> diff --git a/tests/qtest/microbit-test.c b/tests/qtest/microbit-test.c
> index 04e199ec33..6cc1f5d932 100644
> --- a/tests/qtest/microbit-test.c
> +++ b/tests/qtest/microbit-test.c
> @@ -449,9 +449,9 @@ static void test_nrf51_timer(void)
> timer_set_prescaler(qts, 0);
> /* Swept over in first step */
> timer_set_cc(qts, 0, 2);
> - /* Barely miss on first step */
> + /* Barely miss in first step */
> timer_set_cc(qts, 1, 162);
> - /* Spot on on third step */
> + /* Spot on in third step */
> timer_set_cc(qts, 2, 480);
These changes also look wrong.
The rest seems OK.
thanks
-- PMM
- [PATCH v2 0/7] tests: introduce a tree-wide code style checking facility, Daniel P . Berrangé, 2022/07/04
- [PATCH v2 1/7] tests: introduce tree-wide code style checking, Daniel P . Berrangé, 2022/07/04
- [PATCH v2 3/7] tests/style: check for mixups of bool constants with int variables, Daniel P . Berrangé, 2022/07/04
- [PATCH v2 2/7] misc: fix mixups of bool constants with int variables, Daniel P . Berrangé, 2022/07/04
- [PATCH v2 5/7] tests/style: check for commonly doubled up words, Daniel P . Berrangé, 2022/07/04
- [PATCH v2 4/7] misc: fix commonly doubled up words, Daniel P . Berrangé, 2022/07/04
- Re: [PATCH v2 4/7] misc: fix commonly doubled up words,
Peter Maydell <=
- [PATCH v2 7/7] tests/style: check qemu/osdep.h is included in all .c files, Daniel P . Berrangé, 2022/07/04
[PATCH v2 6/7] misc: ensure qemu/osdep.h is included in all .c files, Daniel P . Berrangé, 2022/07/04