[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 3/3] migration/multifd: Warn user when zerocopy not workin
From: |
Daniel P . Berrangé |
Subject: |
Re: [PATCH v3 3/3] migration/multifd: Warn user when zerocopy not working |
Date: |
Tue, 5 Jul 2022 09:05:40 +0100 |
User-agent: |
Mutt/2.2.6 (2022-06-05) |
On Mon, Jul 04, 2022 at 05:23:15PM -0300, Leonardo Bras wrote:
> Some errors, like the lack of Scatter-Gather support by the network
> interface(NETIF_F_SG) may cause sendmsg(...,MSG_ZEROCOPY) to fail on using
> zero-copy, which causes it to fall back to the default copying mechanism.
>
> After each full dirty-bitmap scan there should be a zero-copy flush
> happening, which checks for errors each of the previous calls to
> sendmsg(...,MSG_ZEROCOPY). If all of them failed to use zero-copy, then
> increment dirty_sync_missed_zero_copy migration stat to let the user know
> about it.
>
> Signed-off-by: Leonardo Bras <leobras@redhat.com>
> ---
> migration/ram.h | 2 ++
> migration/multifd.c | 2 ++
> migration/ram.c | 5 +++++
> 3 files changed, 9 insertions(+)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- Re: [PATCH v3 1/3] QIOChannelSocket: Fix zero-copy flush returning code 1 when nothing sent, (continued)
[PATCH v3 2/3] Add dirty-sync-missed-zero-copy migration stat, Leonardo Bras, 2022/07/04
[PATCH v3 3/3] migration/multifd: Warn user when zerocopy not working, Leonardo Bras, 2022/07/04