[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH] usb/hcd-xhci: check slotid in xhci_wakeup_endpoint()
From: |
Mauro Matteo Cascella |
Subject: |
[PATCH] usb/hcd-xhci: check slotid in xhci_wakeup_endpoint() |
Date: |
Tue, 5 Jul 2022 19:47:34 +0200 |
This prevents an OOB read (followed by an assertion failure in
xhci_kick_ep) when slotid > xhci->numslots.
Reported-by: Soul Chen <soulchen8650@gmail.com>
Signed-off-by: Mauro Matteo Cascella <mcascell@redhat.com>
---
hw/usb/hcd-xhci.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c
index 0cd0a5e540..cecf8a0d96 100644
--- a/hw/usb/hcd-xhci.c
+++ b/hw/usb/hcd-xhci.c
@@ -3269,7 +3269,8 @@ static void xhci_wakeup_endpoint(USBBus *bus, USBEndpoint
*ep,
DPRINTF("%s\n", __func__);
slotid = ep->dev->addr;
- if (slotid == 0 || !xhci->slots[slotid-1].enabled) {
+ if (slotid == 0 || slotid > xhci->numslots ||
+ !xhci->slots[slotid-1].enabled) {
DPRINTF("%s: oops, no slot for dev %d\n", __func__, ep->dev->addr);
return;
}
--
2.35.3
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [PATCH] usb/hcd-xhci: check slotid in xhci_wakeup_endpoint(),
Mauro Matteo Cascella <=