Re: [PATCH V2 1/4] softmmu/runstate.c: add RunStateTransition support form COLO to PRELAUNCH

[Jason Wang]

On Wed, Jul 6, 2022 at 1:02 PM Zhang, Chen <chen.zhang@intel.com> wrote:
>
> > > > > > > On Fri, Apr 1, 2022 at 11:59 AM Zhang Chen <chen.zhang@intel.com>
> > wrote:
> > > > > > > >
> > > > > > > > If the checkpoint occurs when the guest finishes restarting
> > > > > > > > but has not started running, the runstate_set() may reject
> > > > > > > > the transition from COLO to PRELAUNCH with the crash log:
> > > > > > > >
> > > > > > > > {"timestamp": {"seconds": 1593484591, "microseconds":
> > > > > > > > 26605},\
> > > > > > > > "event": "RESET", "data": {"guest": true, "reason":
> > > > > > > > "guest-reset"}}
> > > > > > > > qemu-system-x86_64: invalid runstate transition: 'colo' ->
> > 'prelaunch'
> > > > > > > >
> > > > > > > > Long-term testing says that it's pretty safe.
> > > > > > > >
> > > > > > > > Signed-off-by: Like Xu <like.xu@linux.intel.com>
> > > > > > > > Signed-off-by: Zhang Chen <chen.zhang@intel.com>
> > > > > > >
> > > > > > > I'd expect this to get ack from the relevant maintainers.
> > > > > > >
> > > > > >
> > > > > > The scripts/get_maintainer.pl can't find relevant maintainers for 
> > > > > > this
> > patch.
> > > > > > Maybe Paolo have time to cover this simple patch related to 
> > > > > > runstate?
> > > > >
> > > > > No news for a while, any comments for unmaintained files changes ?
> > > > > Ping...
> > > >
> > > > Adding David and Juan.
> > >
> > > This looks OK to me;
> > >
> > > Acked-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> >
> > Great.
> >
> > >
> > > it should be fine to merge it along with the pull that takes the other
> > > patches.
> >
> > Yes, I've queued this series.
>
> Hi Jason,  did this series get lost in the net queue branch?

Unfortunately, yes.

It will be included in the net pull request.

Sorry.

>
> Thanks
> Chen
>
> >
> > Thanks
> >
> > >
> > > Dave
> > >
> > > > Thanks
> > > >
> > > > >
> > >
>