Re: [PATCH 0/2] Hexagon (target/hexagon) bug fixes for mem_noshuf

[Richard Henderson]

On 7/8/22 02:35, Taylor Simpson wrote:
> Recall that the semantics of a Hexagon mem_noshuf packet are that the
> store effectively happens before the load.  There are two bug fixes
> in this series.
>
>
> Taylor Simpson (2):
>    Hexagon (target/hexagon) fix store w/mem_noshuf & predicated load
>    Hexagon (target/hexagon) fix bug in mem_noshuf load exception
>
>   target/hexagon/gen_tcg.h                 |  10 +-
>   target/hexagon/helper.h                  |   1 +
>   target/hexagon/macros.h                  |  37 ++++--
>   target/hexagon/genptr.c                  |   7 ++
>   target/hexagon/op_helper.c               |  23 +++-
>   tests/tcg/hexagon/mem_noshuf.c           | 122 ++++++++++++++++++-
>   tests/tcg/hexagon/mem_noshuf_exception.c | 146 +++++++++++++++++++++++
>   tests/tcg/hexagon/Makefile.target        |   1 +
>   8 files changed, 323 insertions(+), 24 deletions(-)
>   create mode 100644 tests/tcg/hexagon/mem_noshuf_exception.c

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~