Re: [PATCH v2 00/11] Introduce new acpi/smbios python tests using biosbits

[Michael S. Tsirkin]

On Sun, Jul 10, 2022 at 10:30:03PM +0530, Ani Sinha wrote:
> Changelog:
> v2:
>  - a new class of python based tests introduced that is separate from avocado
>    tests or qtests. Can be run by using "make check-pytest".
>  - acpi biosbits tests are the first tests to use pytest environment.
>  - bios bits tests now download the bits binary archives from a remote
>    repository if they are not found locally. The test skips if download
>    fails.
>  - A new environment variable is introduced that can be passed by the tester
>    to specify the location of the bits archives locally. test skips if the
>    bits binaries are not found in that location.
>  - if pip install of python module fails for whatever reaoson, the test skips.
>  - misc code fixes including spell check of the README doc. README has been
>    updated as well.
>  - addition of SPDX license headers to bits test files.
>  - update MAINTAINERS to reflect the new pytest test class.
> 
> For biosbits repo:
>  - added Dockerfile and build script. Made bios bits build on gcc 11.
>    https://github.com/ani-sinha/bits/blob/bits-qemu-logging/Dockerfile
>    https://github.com/ani-sinha/bits/blob/bits-qemu-logging/build-artifacts.sh
>    The build script generates the zip archive and tarball used by the test.

So far so good, I think it's ok for a start. It's probably a good idea
to host the source on qemu.org. Peter - any objection to this?


> v1: initial patchset. uses qtest to implement the bios bits tests.
> 
> Ani Sinha (11):
>   acpi/tests/bits: initial commit of test scripts that are run by
>     biosbits
>   acpi/tests/bits: add SPDX license identifiers for bios bits tests
>   acpi/tests/bits: disable acpi PSS tests that are failing in biosbits
>   acpi/tests/bits: add smilatency test suite from bits in order to
>     disable it
>   acpi/tests/bits: add SPDX license identifiers for bios bits smilatency
>     tests
>   acpi/tests/bits: disable smilatency test since it does not pass
>     everytime
>   acpi/tests/bits: add python test that exercizes QEMU bios tables using
>     biosbits
>   acpi/tests/bits: add biosbits config file for running bios tests
>   acpi/tests/bits: add a README file describing bits pytests
>   pytest: add pytest to the meson build system
>   MAINTAINERS: add myself as the maintainer for acpi biosbits pytests
> 
>  MAINTAINERS                                   |    5 +
>  tests/Makefile.include                        |    4 +-
>  tests/meson.build                             |    1 +
>  tests/pytest/acpi-bits/README                 |  129 +
>  tests/pytest/acpi-bits/acpi-bits-test-venv.sh |   59 +
>  tests/pytest/acpi-bits/acpi-bits-test.py      |  382 +++
>  .../pytest/acpi-bits/bits-config/bits-cfg.txt |   18 +
>  .../pytest/acpi-bits/bits-config/meson.build  |   11 +
>  tests/pytest/acpi-bits/bits-tests/meson.build |   11 +
>  tests/pytest/acpi-bits/bits-tests/smbios.py   | 2432 +++++++++++++++++
>  .../pytest/acpi-bits/bits-tests/smilatency.py |  105 +
>  tests/pytest/acpi-bits/bits-tests/testacpi.py |  285 ++
>  .../pytest/acpi-bits/bits-tests/testcpuid.py  |   85 +
>  tests/pytest/acpi-bits/meson.build            |   33 +
>  tests/pytest/acpi-bits/requirements.txt       |    1 +
>  tests/pytest/meson.build                      |   49 +
>  16 files changed, 3609 insertions(+), 1 deletion(-)
>  create mode 100644 tests/pytest/acpi-bits/README
>  create mode 100644 tests/pytest/acpi-bits/acpi-bits-test-venv.sh
>  create mode 100644 tests/pytest/acpi-bits/acpi-bits-test.py
>  create mode 100644 tests/pytest/acpi-bits/bits-config/bits-cfg.txt
>  create mode 100644 tests/pytest/acpi-bits/bits-config/meson.build
>  create mode 100644 tests/pytest/acpi-bits/bits-tests/meson.build
>  create mode 100644 tests/pytest/acpi-bits/bits-tests/smbios.py
>  create mode 100644 tests/pytest/acpi-bits/bits-tests/smilatency.py
>  create mode 100644 tests/pytest/acpi-bits/bits-tests/testacpi.py
>  create mode 100644 tests/pytest/acpi-bits/bits-tests/testcpuid.py
>  create mode 100644 tests/pytest/acpi-bits/meson.build
>  create mode 100644 tests/pytest/acpi-bits/requirements.txt
>  create mode 100644 tests/pytest/meson.build
> 
> -- 
> 2.25.1